Cache who got the vault waring shown when placing join signs

closes #AddstarMC#270
GreenSurvivors · Sep 3, 2024 · 1fd0a4e · 1fd0a4e
1 parent d1f778f
commit 1fd0a4e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/Minigames/src/main/java/au/com/mineauz/minigames/minigame/Minigame.java b/Minigames/src/main/java/au/com/mineauz/minigames/minigame/Minigame.java
@@ -1066,13 +1066,7 @@ public void setShowCompletionTime(boolean bool) {
     }
 
     public StatSettings getSettings(MinigameStat stat) {
-        StatSettings settings = statSettings.get(stat);
-        if (settings == null) {
-            settings = new StatSettings(stat);
-            statSettings.put(stat, settings);
-        }
-
-        return settings;
+        return statSettings.computeIfAbsent(stat, StatSettings::new);
     }
 
     public Map<MinigameStat, StatSettings> getStatSettings(StoredGameStats stats) {

diff --git a/Minigames/src/main/java/au/com/mineauz/minigames/signs/JoinSign.java b/Minigames/src/main/java/au/com/mineauz/minigames/signs/JoinSign.java
@@ -12,8 +12,11 @@
 import org.bukkit.event.block.SignChangeEvent;
 import org.bukkit.inventory.ItemStack;
 
-public class JoinSign implements MinigameSign {
+import java.util.HashSet;
+import java.util.UUID;
 
+public class JoinSign implements MinigameSign {
+    private static final HashSet<UUID> shownWarning = new HashSet<>();
     private static final Minigames plugin = Minigames.getPlugin();
 
     @Override
@@ -55,7 +58,12 @@ public boolean signCreate(SignChangeEvent event) {
                 }
             } else {
                 event.setLine(3, "");
-                event.getPlayer().sendMessage(ChatColor.RED + MinigameUtils.getLang("minigame.error.noVault"));
+
+                if (!shownWarning.contains(event.getPlayer().getUniqueId())) {
+                    event.getPlayer().sendMessage(ChatColor.RED + MinigameUtils.getLang("minigame.error.noVault"));
+
+                    shownWarning.add(event.getPlayer().getUniqueId());
+                }
             }
             return true;
         }