Adopt the cascading "appearance" attribute in place of Vector::stroke and the "fill"/"paint" attributes - #4433
Conversation
… all paint-writing nodes
…etadata, and editor, cascading from ancestors
…favor of the appearance attribute
…rder of the Fill and Stroke nodes
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 42 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Performance Benchmark Results
|
…reads into single walks
Performance Benchmark Results
|
Keavon
changed the title
…rit instead of blocking the cascade
There was a problem hiding this comment.
All reported issues were addressed across 10 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Performance Benchmark Results
|
Performance Benchmark Results
|
1 participant
Closes #2003
This introduces cascading inheritance of appearance, so any parent group will apply its appearance to shape layers (leaves in the tree) if it lacks an appearance, otherwise it does not. This matches SVG style inheritance, although it applies at the granularity of the appearance as a whole, not per-fill and per-stroke. Because this now opens the door to supporting multiple fills and strokes that was impossible until now.