Skip to content

Add support for opening a .graphite file from a path passed as a launch argument #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

c-mateo
Copy link
Contributor

@c-mateo c-mateo commented Aug 17, 2025

Closes #3054

@Keavon
Copy link
Member

Keavon commented Aug 18, 2025

Neither of your gitignore changes seem to make sense to me. Can you justify or remove them?

@Keavon Keavon requested review from TrueDoctor and timon-schelling and removed request for TrueDoctor August 18, 2025 05:45
@Keavon Keavon changed the title Open document from cli and add some files to .gitignore Add support for opening a .graphite file from a path passed as launch arguments Aug 18, 2025
@Keavon Keavon changed the title Add support for opening a .graphite file from a path passed as launch arguments Add support for opening a .graphite file from a path passed as a launch argument Aug 18, 2025
@timon-schelling
Copy link
Collaborator

timon-schelling commented Aug 18, 2025

I would generally prefer a proper cli implementation from the beginning (with clap etc.), not a temporary solution for only implementing file opening.

@TrueDoctor I would need to implement basically all of this in my wrapper crate pr (#3039). Would you be fine with waiting with features that will have a easy way of implementing once the wrapper crate separation is done?

@c-mateo
Copy link
Contributor Author

c-mateo commented Aug 18, 2025

Neither of your gitignore changes seem to make sense to me. Can you justify or remove them?

I added those lines because I haven't created those folders but they were there as a result of a compilation step. Let me remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow opening document passed as cli arg
3 participants