Skip to content

Fix node deletion being too greedy #2619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

Fix node deletion being too greedy #2619

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d51c2a9
fix too greedy node deletion search
Apr 25, 2025
1d1d22e
Merge branch 'GraphiteEditor:master' into master
Daniel53245 Apr 25, 2025
ae68df2
Merge branch 'master' into master
Keavon Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion editor/src/messages/portfolio/document/utility_types/network_interface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4200,7 +4200,8 @@ impl NodeNetworkInterface {
if let InputConnector::Node { node_id: downstream_id, .. } = downstream_node {
let downstream_node_output = OutputConnector::node(*downstream_id, 0);
if !delete_nodes.contains(downstream_id) {
stack.push(downstream_node_output);
can_delete = false;
break;
}
// Continue traversing over the downstream sibling, if the current node is a sibling to a node that will be deleted and it is a layer
else {
Expand Down
Loading