Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer/airflow_1_samples/requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
pytest==8.2.0
cloud-composer-dag-test-utils==0.0.1
cloud-composer-dag-test-utils==1.0.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update introduces a dependency on Airflow 2.x, which is incompatible with the Airflow 1.x samples in this directory. The setup.py for cloud-composer-dag-test-utils==1.0.0 specifies install_requires=["apache-airflow[google] >= 2.0.0, < 3.0.0"]. However, the code in composer/airflow_1_samples/ is intended for Airflow 1.x, as indicated by the directory name and contents like conftest.py. This version bump will break the tests for the Airflow 1 samples. This change should be reverted.

cloud-composer-dag-test-utils==0.0.1