Skip to content

chore: migrate cleanup commands from gsutil to gcloud storage #13732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iennae merged 3 commits into from
Jan 12, 2026
Merged

chore: migrate cleanup commands from gsutil to gcloud storage #13732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d69eea7
chore: migrate cleanup commands from gsutil to gcloud storage
bhandarivijay-png Jan 9, 2026
4aa4cb4
chore: migrate cleanup commands from gsutil to gcloud storage
bhandarivijay-png Jan 9, 2026
22fb0be
Merge branch 'main' into python-docs-samples-changes
iennae Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion people-and-planet-ai/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def bucket_name(test_name: str, location: str, unique_id: str) -> Iterable[str]:
# Try to remove all files before deleting the bucket.
# Deleting a bucket with too many files results in an error.
try:
run_cmd("gsutil", "-m", "rm", "-rf", f"gs://{bucket_name}/*")
run_cmd("gcloud", "storage", "rm", "--recursive", f"gs://{bucket_name}/**")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For clarity and to follow documented best practices, you can remove the /** wildcard. The gcloud storage rm --recursive command, when applied to a bucket URL, is sufficient to delete all objects within it.

The official documentation and migration guides recommend gcloud storage rm gs://my-bucket --recursive as the idiomatic way to empty a bucket. This makes the command cleaner.

Suggested change
run_cmd("gcloud", "storage", "rm", "--recursive", f"gs://{bucket_name}/**")
run_cmd("gcloud", "storage", "rm", "--recursive", f"gs://{bucket_name}")

except RuntimeError:
# If no files were found and it fails, ignore the error.
pass
Expand Down
2 changes: 1 addition & 1 deletion pubsublite/spark-connector/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Get the connector's uber jar from this [public Cloud Storage location]. Alternat
```bash
export BUCKET_ID=your-gcs-bucket-id

gsutil mb gs://$BUCKET_ID
gcloud storage buckets create gs://$BUCKET_ID
```

## Python setup
Expand Down