PO to GMP Migration Tool: Add README - #2072
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the gmp-migrate CLI tool to the main README and replaces the placeholder README in cmd/gmp-migrate/README.md with comprehensive documentation detailing supported resources, translation parity, installation, usage, and safety guardrails. A review comment identifies an inaccuracy in the documentation regarding the collector's behavior for followRedirects and enableHttp2, which contradicts the actual implementation and should be corrected.
karthunni
marked this pull request as ready for review
August 18, 2026 03:59
dashpole
self-requested a review
August 18, 2026 08:55
bwplotka
reviewed
Aug 18, 2026
bwplotka
left a comment
Collaborator
There was a problem hiding this comment.
Looks super nice! Some comments, but overall great work!
karthunni
force-pushed
the
karthunni/po-migrate-readme
branch
from
August 18, 2026 15:51
e310d44 to
3e43088
Compare
dashpole
approved these changes
Aug 19, 2026
karthunni
force-pushed
the
karthunni/po-migrate-readme
branch
2 times, most recently
from
August 20, 2026 14:18
11007d2 to
158e977
Compare
karthunni
force-pushed
the
karthunni/po-migrate-readme
branch
from
August 20, 2026 23:06
158e977 to
d1a32bc
Compare
karthunni
force-pushed
the
karthunni/po-migrate-readme
branch
from
August 21, 2026 12:52
d1a32bc to
16f19a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.