Skip to content

PO to GMP Migration Tool: Add README - #2072

Merged
karthunni merged 4 commits into
mainfrom
karthunni/po-migrate-readme
Aug 21, 2026
Merged

PO to GMP Migration Tool: Add README#2072
karthunni merged 4 commits into
mainfrom
karthunni/po-migrate-readme

Conversation

@karthunni

Copy link
Copy Markdown
Collaborator

No description provided.

@karthunni karthunni self-assigned this Aug 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the gmp-migrate CLI tool to the main README and replaces the placeholder README in cmd/gmp-migrate/README.md with comprehensive documentation detailing supported resources, translation parity, installation, usage, and safety guardrails. A review comment identifies an inaccuracy in the documentation regarding the collector's behavior for followRedirects and enableHttp2, which contradicts the actual implementation and should be corrected.

Comment thread cmd/gmp-migrate/README.md Outdated
@karthunni
karthunni marked this pull request as ready for review August 18, 2026 03:59
@dashpole
dashpole self-requested a review August 18, 2026 08:55

@bwplotka bwplotka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super nice! Some comments, but overall great work!

Comment thread cmd/gmp-migrate/README.md Outdated
Comment thread cmd/gmp-migrate/README.md Outdated
Comment thread cmd/gmp-migrate/README.md Outdated
Comment thread cmd/gmp-migrate/README.md
Comment thread cmd/gmp-migrate/README.md Outdated
Comment thread cmd/gmp-migrate/README.md Outdated
Comment thread cmd/gmp-migrate/README.md Outdated
Comment thread cmd/gmp-migrate/README.md
@karthunni
karthunni force-pushed the karthunni/po-migrate-readme branch from e310d44 to 3e43088 Compare August 18, 2026 15:51

@bwplotka bwplotka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@karthunni
karthunni force-pushed the karthunni/po-migrate-readme branch 2 times, most recently from 11007d2 to 158e977 Compare August 20, 2026 14:18
Base automatically changed from karthunni/po-migrate-skill to main August 20, 2026 23:06
@karthunni
karthunni force-pushed the karthunni/po-migrate-readme branch from 158e977 to d1a32bc Compare August 20, 2026 23:06
@karthunni
karthunni force-pushed the karthunni/po-migrate-readme branch from d1a32bc to 16f19a9 Compare August 21, 2026 12:52
@karthunni
karthunni merged commit b918d5c into main Aug 21, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants