Revert "chore: upgrade texttospeech samples to new surface" #1902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 18c6872.
product-auto-label
bot
added
the
samples
pattishin
pushed a commit
that referenced
this pull request
Aug 1, 2023
pattishin
pushed a commit
that referenced
this pull request
Aug 1, 2023
pattishin
pushed a commit
that referenced
this pull request
Aug 2, 2023
pattishin
added a commit
that referenced
this pull request
Aug 25, 2023
* feat: initial commit of run mc php nginx sample * chore: upgrade texttospeech samples to new surface (#1880) * Revert "chore: upgrade texttospeech samples to new surface (#1880)" (#1902) This reverts commit 18c6872. * test: update php mc test and check deployment logs * test: updating test and clean up * chore: clean up * refactor: rename test * Update run/multi-container/hello-php-nginx-sample/nginx/nginx.conf Co-authored-by: Julien Breux <[email protected]> * Update run/multi-container/hello-php-nginx-sample/Makefile Co-authored-by: Julien Breux <[email protected]> * fix: flip container deps * Update run/multi-container/hello-php-nginx-sample/php-app/Dockerfile Co-authored-by: Adam Ross <[email protected]> * Update run/multi-container/hello-php-nginx-sample/php-app/opcache.ini Co-authored-by: Adam Ross <[email protected]> * Update run/multi-container/hello-php-nginx-sample/README.md Co-authored-by: Adam Ross <[email protected]> * refactor: updating with suggestions (updating readme, Cloud Run memory limit updates, rm makefile, add composer) * fix: resolve snippet-bot failures about lack of product name * refactor: update .ini and readme with concurrency/memory info * chore: clean up readme * refactor: updating comment about dockerfile context --------- Co-authored-by: Brent Shaffer <[email protected]> Co-authored-by: Yash Sahu <[email protected]> Co-authored-by: Julien Breux <[email protected]> Co-authored-by: Adam Ross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1880
As this need not to be merged until the new surface is GA.
More details at #1886