-
Notifications
You must be signed in to change notification settings - Fork 381
chore(deps): update dependency eslint-plugin-prettier to v5 #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update dependency eslint-plugin-prettier to v5 #654
Conversation
|
/gcbrun |
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates eslint-plugin-prettier to version 5. This is a major version update which requires prettier version 3 and eslint-config-prettier version 9. The current configuration uses older, incompatible versions of these packages, which will cause issues. I've suggested updating all related Prettier dependencies to their compatible major versions to ensure the linting setup works correctly.
| "eslint-config-prettier": "^8.0.0", | ||
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-prettier": "^4.0.0", | ||
| "eslint-plugin-prettier": "^5.0.0", | ||
| "prettier": "^2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating eslint-plugin-prettier to v5 requires updating its peer dependencies as well. eslint-plugin-prettier v5 is designed to work with prettier v3 and eslint-config-prettier v9. The current dependencies for prettier (v2) and eslint-config-prettier (v8) are incompatible and will break your linting setup. All three packages should be updated together to ensure compatibility.
| "eslint-config-prettier": "^8.0.0", | |
| "eslint-plugin-node": "^11.1.0", | |
| "eslint-plugin-prettier": "^4.0.0", | |
| "eslint-plugin-prettier": "^5.0.0", | |
| "prettier": "^2.0.0" | |
| "eslint-config-prettier": "^9.0.0", | |
| "eslint-plugin-node": "^11.1.0", | |
| "eslint-plugin-prettier": "^5.0.0", | |
| "prettier": "^3.0.0" |
This PR contains the following updates:
^4.0.0->^5.0.0Release Notes
prettier/eslint-plugin-prettier (eslint-plugin-prettier)
v5.5.4Compare Source
Patch Changes
#755
723f7a8Thanks @kbrilla! - fix: add 'oxc', 'oxc-ts' and 'hermes' parsers toparserBlocklist#751
cf52b30Thanks @andreww2012! - fix: disallow extra properties in rule optionsv5.5.3Compare Source
republish the latest version
Full Changelog: prettier/eslint-plugin-prettier@v5.5.2...v5.5.3
v5.5.2Compare Source
republish the latest version
Full Changelog: prettier/eslint-plugin-prettier@v5.5.1...v5.5.2
v5.5.1Compare Source
Patch Changes
bfd1e95Thanks @JounQin! - fix: useprettierRcOptionsdirectly for prettier 3.6+v5.5.0Compare Source
Minor Changes
92f2c9cThanks @dotcarmen! - feat: support non-js languages likecssfor@eslint/cssandjsonfor@eslint/jsonv5.4.1Compare Source
Patch Changes
c21521fThanks @JounQin! - fix(deps): bumpsynckitto v0.11.7 to fix potentialTypeError: Cannot read properties of undefined (reading 'message')errorv5.4.0Compare Source
Minor Changes
59a0caeThanks @yashtech00! - refactor: migrateworker.jstoworker.mjsv5.3.1Compare Source
Patch Changes
dcf2c80Thanks @JounQin! - ci: enableNPM_CONFIG_PROVENANCEenvv5.3.0Compare Source
Minor Changes
6fe0c90Thanks @irsooti! - feat(types): preferConfigoverFlatConfigwhen they're equalv5.2.6Compare Source
Patch Changes
1451176Thanks @renovate! - fix(deps): bumpsynckittov0.11.0v5.2.5Compare Source
Patch Changes
4f5513dThanks @JounQin! - fix: clarify correcteslint-config-prettierpeer rangev5.2.4Compare Source
Patch Changes
b8cfe56Thanks @JounQin! - chore: hourcekeeping, bump all (dev) depsv5.2.3Compare Source
Patch Changes
9c6141fThanks @BPScott! - Add name field to recommended flat configv5.2.2Compare Source
Patch Changes
aa5b59fThanks @ntnyq! - fix: report node when loc not foundv5.2.1Compare Source
Patch Changes
ac036ccThanks @OrlovAlexei! - build(deps): Bump synckit from 0.8.6 to 0.9.1v5.1.3Compare Source
Patch Changes
985b33cThanks @JounQin! - chore: addpackage.jsonintoexportsmapv5.1.2Compare Source
Patch Changes
#623
8210e44Thanks @BPScott! - Add exports mapping to package.json, to allowimport eslintPluginRecommended from 'eslint-plugin-prettier/recommended'to work as expected.Strictly speaking this is a breaking change as it removes the ability for people to import from "eslint-plugin-prettier/eslint-plugin-prettier.js" and "eslint-plugin-prettier/recommended.js" but the former was never recommended in the first place and the latter has only been available for a few days.
#621
2b09e7fThanks @JounQin! - feat: support parsingmarkdownviaeslint-mdxnativelyWhat means the following is unnecessary anymore when using with
eslint-mdx/eslint-plugin-mdx!v5.1.1Compare Source
Patch Changes
b5c0dc5Thanks @JounQin! - chore: skip formatting inline scripts in pug filesv5.1.0Compare Source
Minor Changes
#616
3856413Thanks @BPScott! - Add recommended config for the flat config format.If you are using flat config, import the recommended config from
eslint-plugin-prettier/recommended. Like the legacy format recommended config, this automatically includes the contents ofeslint-config-prettier.Patch Changes
#614
5270877Thanks @BPScott! - Add meta block to plugin. This improves debugging and cachebusting when using the new flat config#603
a63a570Thanks @filiptammergard! - fix: specifyeslint-config-prettieras peer dependencyIt's already added to
peerDependenciesMetaas optional, which means it should also be specified inpeerDependencies.v5.0.1Compare Source
Patch Changes
21a7146Thanks @krist7599555! - fix:parserPathtype might beundefinedon Eslint Falt Configv5.0.0Compare Source
Major Changes
#508
910aeb6Thanks @JounQin! - feat!: bump peer eslint to ">=8.0.0" and node to "^14.18.0 || >=16.0.0"#508
910aeb6Thanks @JounQin! - feat!: upgrade to prettier v3Minor Changes
910aeb6Thanks @JounQin! - feat: add typings supportPatch Changes
#548
82a3db8Thanks @fisker! - fix: add missing dependencysynckit#564
ae7a73cThanks @auvred! - fix: compatibility with prettier@3 without pluginsConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.