Skip to content

Conversation

thiyaguk09
Copy link

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 11, 2025
@thiyaguk09 thiyaguk09 force-pushed the storagebatchoperations-samples branch from e7476df to c1d08bd Compare September 12, 2025 07:52
@thiyaguk09 thiyaguk09 marked this pull request as ready for review September 12, 2025 09:52
@thiyaguk09 thiyaguk09 requested review from a team as code owners September 12, 2025 09:52
Copy link

snippet-bot bot commented Sep 12, 2025

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@thiyaguk09 thiyaguk09 force-pushed the storagebatchoperations-samples branch from c1d08bd to b424e2c Compare September 22, 2025 08:15
@thiyaguk09
Copy link
Author

@ddelgrosso1 Just a friendly reminder to review this PR when you get a chance. Thanks!

@thiyaguk09
Copy link
Author

@ddelgrosso1 Could you please merge this PR if possible?

…on & Error Handling)

Improve the robustness and clarity of the Storage Batch Operations API
samples:

* **Error Handling:** Wraps all asynchronous Batch Operations API
samples (Create, Get, List, Cancel) in `try...catch` blocks for
production readiness.
* **Specific Diagnostics:** Adds specific gRPC error code checks
(`NOT_FOUND`, `FAILED_PRECONDITION`) within the `catch` blocks to
provide detailed diagnostic feedback to users regarding job state or
non-existence.
* **Documentation:** Clarifies JSDoc for all function parameters (e.g.,
`projectId`, `jobId`, `objectPrefix`), ensuring examples and types are
clear for developers.
@thiyaguk09 thiyaguk09 force-pushed the storagebatchoperations-samples branch from fb51efe to 6f5d870 Compare October 17, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants