Skip to content

Deprecate auto scaling for WorkerPools.#16651

Draft
paridhishah18 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
paridhishah18:auto-scaling-wp
Draft

Deprecate auto scaling for WorkerPools.#16651
paridhishah18 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
paridhishah18:auto-scaling-wp

Conversation

@paridhishah18
Copy link
Contributor

@paridhishah18 paridhishah18 commented Mar 10, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Deprecating `scalingMode` , `minInstance` ,  `maxInstance` for WorkerPool.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 12 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 12 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_worker_pool (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_worker_pool" "primary" {
  scaling {
    max_instance_count = # value needed
    min_instance_count = # value needed
    scaling_mode       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 12 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 12 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_worker_pool (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_worker_pool" "primary" {
  scaling {
    max_instance_count = # value needed
    min_instance_count = # value needed
    scaling_mode       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 77
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceWithManualScaling

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceWithManualScaling [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 77
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceWithManualScaling

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceWithManualScaling [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 12 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 12 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_worker_pool (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_worker_pool" "primary" {
  scaling {
    max_instance_count = # value needed
    min_instance_count = # value needed
    scaling_mode       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 77
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceWithManualScaling

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceWithManualScaling [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 12 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 12 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_worker_pool (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_worker_pool" "primary" {
  scaling {
    max_instance_count = # value needed
    min_instance_count = # value needed
    scaling_mode       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 78
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • cloudrunv2

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_worker_pool (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_worker_pool" "primary" {
  scaling {
    max_instance_count = # value needed
    min_instance_count = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 76
Skipped tests: 9
Affected tests: 2

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithManualInstanceCountZero
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithManualScaling

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithManualInstanceCountZero [Error message] [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithManualScaling [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 12 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 12 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_worker_pool (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_worker_pool" "primary" {
  scaling {
    max_instance_count = # value needed
    min_instance_count = # value needed
    scaling_mode       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 78
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • cloudrunv2

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants