Skip to content

Fix asset names for container cluster#16647

Draft
trodge wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
trodge:tgc-container-cluster-metadata
Draft

Fix asset names for container cluster#16647
trodge wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
trodge:tgc-container-cluster-metadata

Conversation

@trodge
Copy link
Contributor

@trodge trodge commented Mar 9, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@trodge trodge requested a review from zli82016 March 9, 2026 21:35
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 10 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 1 file changed, 10 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6135
Passed tests: 5495
Skipped tests: 638
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataformConfig_update
  • TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_update [Debug log]
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 10 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 1 file changed, 10 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+))


func GetContainerCluster(d tpgresource.TerraformResourceData, config *transport.Config) ([]caiasset.Asset, error) {
name, err := cai.AssetName(d, config, "//container.googleapis.com/projects/{{project}}/locations/{{location}}/clusters/{{name}}")
if v, ok := d.GetOk("location"); ok && tpgresource.IsZone(v.(string)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, the changes in tgc_utils.go are not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants