Skip to content

add Forward_proxy to compute.backendService DynamicForwarding#16642

Closed
pawelJas wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
pawelJas:add-backend-service-dynamic-forwarding-beta
Closed

add Forward_proxy to compute.backendService DynamicForwarding#16642
pawelJas wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
pawelJas:add-backend-service-dynamic-forwarding-beta

Conversation

@pawelJas
Copy link
Contributor

@pawelJas pawelJas commented Mar 9, 2026

Add ForwardProxy to regional and global Backend Service DynamicForwarding

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `ForwardProxy` field to `google_compute_region_backend_service` resource

@pawelJas pawelJas force-pushed the add-backend-service-dynamic-forwarding-beta branch from ceffb4e to bd6e023 Compare March 9, 2026 14:18
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 32 insertions(+))
google-beta provider: Diff ( 6 files changed, 218 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 88 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  dynamic_forwarding {
    forward_proxy {
      enabled    = # value needed
      proxy_mode = # value needed
    }
  }
}

Resource: google_compute_region_backend_service (231 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  dynamic_forwarding {
    forward_proxy {
      enabled    = # value needed
      proxy_mode = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 75 insertions(+))
google-beta provider: Diff ( 8 files changed, 344 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 88 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  dynamic_forwarding {
    forward_proxy {
      enabled    = # value needed
      proxy_mode = # value needed
    }
  }
}

Resource: google_compute_region_backend_service (231 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  dynamic_forwarding {
    forward_proxy {
      enabled    = # value needed
      proxy_mode = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1382
Passed tests: 1290
Skipped tests: 90
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_backendServiceDynamicForwardingForwardProxyExample
  • TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceDynamicForwardingForwardProxyExample [Error message] [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1382
Passed tests: 1290
Skipped tests: 90
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_backendServiceDynamicForwardingForwardProxyExample
  • TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceDynamicForwardingForwardProxyExample [Error message] [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@pawelJas pawelJas force-pushed the add-backend-service-dynamic-forwarding-beta branch from bd6e023 to 7e6eda8 Compare March 10, 2026 14:24
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 79 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 8 files changed, 348 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 89 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1384
Passed tests: 1292
Skipped tests: 90
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_backendServiceDynamicForwardingForwardProxyExample
  • TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceDynamicForwardingForwardProxyExample [Error message] [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceDynamicForwardingForwardProxyExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@pawelJas pawelJas force-pushed the add-backend-service-dynamic-forwarding-beta branch from 7e6eda8 to 1ccf00f Compare March 10, 2026 19:27
@pawelJas pawelJas closed this Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants