Add identityType, effectiveIdentity, and default_from_api to Vertex A…#16638
Add identityType, effectiveIdentity, and default_from_api to Vertex A…#16638mmontan wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
…I ReasoningEngine
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 85 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
| enum_values: | ||
| - 'SERVICE_ACCOUNT' | ||
| - 'AGENT_IDENTITY' | ||
| api_name: 'identityType' |
There was a problem hiding this comment.
api_name: 'identityType' is not needed, as the api_name will be identityType by default.
| description: |- | ||
| The identity to use for the Reasoning Engine. | ||
| output: true | ||
| api_name: 'effectiveIdentity' |
| CheckDestroy: testAccCheckVertexAIEndpointDestroyProducer(t), | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccVertexAIReasoningEngine_identityTypeServiceAccount(), |
There was a problem hiding this comment.
context with the field random_suffix should be passed to the function.
| resource "google_vertex_ai_reasoning_engine" "reasoning_engine" { | ||
| provider = google-beta | ||
|
|
||
| display_name = "sample-reasoning-engine" |
There was a problem hiding this comment.
| display_name = "sample-reasoning-engine" | |
| display_name = "tf-test-sample-reasoning-engine%{random_suffix}" |
| resource "google_vertex_ai_reasoning_engine" "reasoning_engine" { | ||
| provider = google-beta | ||
|
|
||
| display_name = "sample-reasoning-engine" |
There was a problem hiding this comment.
| display_name = "sample-reasoning-engine" | |
| display_name = "tf-test-sample-reasoning-engine%{random_suffix}" |
Add identityType, effectiveIdentity, and default_from_api to google_vertex_ai_reasoning_engine (beta)
This PR adds two new beta fields to the spec block of google_vertex_ai_reasoning_engine:
Additionally, default_from_api: true is added to the spec field to allow the API to populate defaults, as effective_identity is an output field computed server-side.
An acceptance test (TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate) is included to verify updating between SERVICE_ACCOUNT and AGENT_IDENTITY identity types using the beta provider.
Fixed hashicorp/terraform-provider-google#26376
Fixed hashicorp/terraform-provider-google#25101
Release Note Template for Downstream PRs (will be copied)