Skip to content

Add identityType, effectiveIdentity, and default_from_api to Vertex A…#16638

Open
mmontan wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
mmontan:vertex-ai-reasoning-engine-identity
Open

Add identityType, effectiveIdentity, and default_from_api to Vertex A…#16638
mmontan wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
mmontan:vertex-ai-reasoning-engine-identity

Conversation

@mmontan
Copy link
Contributor

@mmontan mmontan commented Mar 7, 2026

Add identityType, effectiveIdentity, and default_from_api to google_vertex_ai_reasoning_engine (beta)

This PR adds two new beta fields to the spec block of google_vertex_ai_reasoning_engine:

  • identity_type (beta): Specifies the identity type to use for the Reasoning Engine. Accepts SERVICE_ACCOUNT (uses a custom service account if set, otherwise the default Vertex AI Reasoning Engine Service Agent) or AGENT_IDENTITY (uses Agent Identity; service_account must not be set).
  • effective_identity (beta, output-only): Reports the effective identity in use for the Reasoning Engine.

Additionally, default_from_api: true is added to the spec field to allow the API to populate defaults, as effective_identity is an output field computed server-side.

An acceptance test (TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate) is included to verify updating between SERVICE_ACCOUNT and AGENT_IDENTITY identity types using the beta provider.

Fixed hashicorp/terraform-provider-google#26376
Fixed hashicorp/terraform-provider-google#25101


Release Note Template for Downstream PRs (will be copied)

vertexai: added `spec.identity_type` and `spec.effective_identity` fields to `google_vertex_ai_reasoning_engine` resource (beta)

@github-actions github-actions bot requested a review from zli82016 March 7, 2026 17:43
@github-actions
Copy link

github-actions bot commented Mar 7, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 77 insertions(+))
google-beta provider: Diff ( 4 files changed, 129 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • vertexai

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineSourceUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineSourceUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

enum_values:
- 'SERVICE_ACCOUNT'
- 'AGENT_IDENTITY'
api_name: 'identityType'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api_name: 'identityType' is not needed, as the api_name will be identityType by default.

description: |-
The identity to use for the Reasoning Engine.
output: true
api_name: 'effectiveIdentity'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api_name is not needed

CheckDestroy: testAccCheckVertexAIEndpointDestroyProducer(t),
Steps: []resource.TestStep{
{
Config: testAccVertexAIReasoningEngine_identityTypeServiceAccount(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource "google_vertex_ai_reasoning_engine" "reasoning_engine" {
provider = google-beta

display_name = "sample-reasoning-engine"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
display_name = "sample-reasoning-engine"
display_name = "tf-test-sample-reasoning-engine%{random_suffix}"

resource "google_vertex_ai_reasoning_engine" "reasoning_engine" {
provider = google-beta

display_name = "sample-reasoning-engine"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
display_name = "sample-reasoning-engine"
display_name = "tf-test-sample-reasoning-engine%{random_suffix}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants