Add retry for GCE 403 concurrent operations quota errors#16625
Add retry for GCE 403 concurrent operations quota errors#16625golgeek wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Signed-off-by: Ludovic Leroux <ludo.leroux@cockroachlabs.com>
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 6134 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Thanks for looking at the PR and triggering the tests, @trodge! It looks like the Let me know if you need me to do anything! |
GCE returns HTTP 403 (not 429) when the concurrent operations quota is exceeded.
The error includes reason
CONCURRENT_OPERATIONS_QUOTA_EXCEEDEDin the error details.This is a transient condition that clears as soon as in-flight operations complete, but the provider currently treats it as a hard failure.
This adds a new global retry predicate
is403ConcurrentOperationsQuotaErrorthat matches 403 errors withCONCURRENT_OPERATIONS_QUOTA_EXCEEDEDin theErrorInfodetails and retries them automatically.Fixes hashicorp/terraform-provider-google#9207
Release Note Template