Feature/aspects on entry links#16621
Feature/aspects on entry links#16621AnujJhunjhunwala wants to merge 13 commits intoGoogleCloudPlatform:mainfrom
Conversation
Add support for creating aspects on entry links
…o feature/aspects-on-entry-links
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
hao-nan-li
left a comment
There was a problem hiding this comment.
Could you sign the CLA?
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 6133 Click here to see the affected service packages
Action takenFound 78 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Add support for aspects on entry links
This change will allow users to:-