Skip to content

Feature/aspects on entry links#16621

Open
AnujJhunjhunwala wants to merge 13 commits intoGoogleCloudPlatform:mainfrom
AnujJhunjhunwala:feature/aspects-on-entry-links
Open

Feature/aspects on entry links#16621
AnujJhunjhunwala wants to merge 13 commits intoGoogleCloudPlatform:mainfrom
AnujJhunjhunwala:feature/aspects-on-entry-links

Conversation

@AnujJhunjhunwala
Copy link

@AnujJhunjhunwala AnujJhunjhunwala commented Mar 5, 2026

Add support for aspects on entry links

This change will allow users to:-

  1. Create Aspects on Entry Links
  2. Update Aspects on Entry Links
dataplex: added `aspects` field to `google_dataplex_entry_link` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 5, 2026
@google-cla
Copy link

google-cla bot commented Mar 5, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from hao-nan-li March 5, 2026 12:50
Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sign the CLA?

@modular-magician modular-magician added service/dataplex and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 9, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1256 insertions(+), 68 deletions(-))
google-beta provider: Diff ( 6 files changed, 1256 insertions(+), 68 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 291 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6133
Passed tests: 5417
Skipped tests: 638
Affected tests: 78

Click here to see the affected service packages

All service packages are affected

Action taken

Found 78 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApiGatewayApiConfigIamBindingGenerated
  • TestAccApiGatewayApiConfigIamMemberGenerated
  • TestAccApiGatewayApiConfigIamPolicyGenerated
  • TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample
  • TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated
  • TestAccApiGatewayApiConfig_apigatewayApiConfigFullExample
  • TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcExample
  • TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcFullExample
  • TestAccApiGatewayApiIamBindingGenerated
  • TestAccApiGatewayApiIamMemberGenerated
  • TestAccApiGatewayApiIamPolicyGenerated
  • TestAccApiGatewayApi_apigatewayApiBasicExample
  • TestAccApiGatewayApi_apigatewayApiBasicExampleUpdated
  • TestAccApiGatewayApi_apigatewayApiFullExample
  • TestAccApiGatewayGatewayIamBindingGenerated
  • TestAccApiGatewayGateway_apigatewayGatewayFullExample
  • TestAccApigeeAddonsConfig_apigeeAddonsTestExample
  • TestAccApigeeApiProduct_apigeeApiProductBasicTestExample
  • TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample
  • TestAccApigeeApiProduct_apigeeApiProduct_full
  • TestAccApigeeControlPlaneAccess_update
  • TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample
  • TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
  • TestAccApigeeEnvironmentIamBindingGenerated
  • TestAccApigeeEnvironmentIamMemberGenerated
  • TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesBetaTestExample
  • TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesTestExample
  • TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsBetaTestExample
  • TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationDrzTestExample
  • TestAccApigeeSecurityFeedback_apigeeSecurityFeedbackBasicTestExample
  • TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample
  • TestAccApigeeSyncAuthorization_update
  • TestAccApigeeTargetServer_apigeeTargetServerTestExample
  • TestAccApihubHostProjectRegistration_apihubHostProjectRegistrationBasicExample
  • TestAccApphubBoundary_apphubBoundary_update
  • TestAccApphubServiceProjectAttachment_serviceProjectAttachmentBasicExample
  • TestAccApphubService_apphubServiceBasicExample
  • TestAccApphubService_apphubServiceFullExample
  • TestAccApphubService_serviceUpdate
  • TestAccApphubWorkload_apphubWorkloadBasicExample
  • TestAccApphubWorkload_apphubWorkloadFullExample
  • TestAccApphubWorkload_apphubWorkloadUpdate
  • TestAccArtifactRegistryRepositoryIamBindingGenerated
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryBasicExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryMultiRegionExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithCustomUpstreamExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithDockerExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryVirtualExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryVulnerabilityScanningExample
  • TestAccArtifactRegistryRepository_cleanup
  • TestAccArtifactRegistryRepository_createMvnRelease
  • TestAccArtifactRegistryRepository_remote
  • TestAccAssuredWorkloadsWorkload_BasicHandWritten
  • TestAccAssuredWorkloadsWorkload_FullHandWritten
  • TestAccBigqueryConnectionConnectionIamPolicyGenerated
  • TestAccBigqueryConnectionConnection_bigqueryConnectionAwsExample
  • TestAccBigqueryConnectionConnection_bigqueryConnectionAwsUpdate
  • TestAccBigqueryConnectionConnection_bigqueryConnectionCloudspannerDataboostExample
  • TestAccBigqueryConnectionConnection_bigqueryConnectionCloudspannerExample
  • TestAccDataSourceApphubDiscoveredService_basic
  • TestAccDataSourceArtifactRegistryPackage_basic
  • TestAccDataSourceArtifactRegistryPackages_basic
  • TestAccDataSourceArtifactRegistryTags_basic
  • TestAccDataSourceArtifactRegistryVersion_basic
  • TestAccDataSourceArtifactRegistryVersions_basic
  • TestAccDataSourceGoogleArtifactRegistryLocations_basic
  • TestAccDataSourceGoogleArtifactRegistryRepositoryConfig
  • TestAccDataSourceGoogleBackupDRBackupPlanAssociation_MultiRegion
  • TestAccDataSourceGoogleBackupDRDataSourceReference_MultiRegion
  • TestAccDataSourceGoogleBackupDRDataSourceReference_basic
  • TestAccDataformConfig_update
  • TestAccDataplexEntryLink_dataplexEntryLinkWithAspectExample
  • TestAccDataplexEntryLink_update
  • TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApiGatewayApiConfigIamBindingGenerated [Debug log]
TestAccApiGatewayApiConfigIamMemberGenerated [Debug log]
TestAccApiGatewayApiConfigIamPolicyGenerated [Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample [Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated [Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigFullExample [Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcExample [Debug log]
TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcFullExample [Debug log]
TestAccApiGatewayApiIamBindingGenerated [Debug log]
TestAccApiGatewayApiIamMemberGenerated [Debug log]
TestAccApiGatewayApiIamPolicyGenerated [Debug log]
TestAccApiGatewayApi_apigatewayApiBasicExample [Debug log]
TestAccApiGatewayApi_apigatewayApiBasicExampleUpdated [Debug log]
TestAccApiGatewayApi_apigatewayApiFullExample [Debug log]
TestAccApiGatewayGatewayIamBindingGenerated [Debug log]
TestAccApiGatewayGateway_apigatewayGatewayFullExample [Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample [Debug log]
TestAccApigeeApiProduct_apigeeApiProductBasicTestExample [Debug log]
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Debug log]
TestAccApigeeApiProduct_apigeeApiProduct_full [Debug log]
TestAccApigeeControlPlaneAccess_update [Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample [Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update [Debug log]
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Debug log]
TestAccApigeeEnvironmentIamBindingGenerated [Debug log]
TestAccApigeeEnvironmentIamMemberGenerated [Debug log]
TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesBetaTestExample [Debug log]
TestAccApigeeEnvironmentKeyvaluemapsEntries_apigeeEnvironmentKeyvaluemapsEntriesTestExample [Debug log]
TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsBetaTestExample [Debug log]
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Debug log]
TestAccApigeeOrganization_apigeeOrganizationDrzTestExample [Debug log]
TestAccApigeeSecurityFeedback_apigeeSecurityFeedbackBasicTestExample [Debug log]
TestAccApigeeSyncAuthorization_apigeeSyncAuthorizationBasicTestExample [Debug log]
TestAccApigeeSyncAuthorization_update [Debug log]
TestAccApigeeTargetServer_apigeeTargetServerTestExample [Debug log]
TestAccApihubHostProjectRegistration_apihubHostProjectRegistrationBasicExample [Debug log]
TestAccApphubBoundary_apphubBoundary_update [Debug log]
TestAccApphubServiceProjectAttachment_serviceProjectAttachmentBasicExample [Debug log]
TestAccApphubService_apphubServiceBasicExample [Debug log]
TestAccApphubService_apphubServiceFullExample [Debug log]
TestAccApphubService_serviceUpdate [Debug log]
TestAccApphubWorkload_apphubWorkloadBasicExample [Debug log]
TestAccApphubWorkload_apphubWorkloadFullExample [Debug log]
TestAccApphubWorkload_apphubWorkloadUpdate [Debug log]
TestAccArtifactRegistryRepositoryIamBindingGenerated [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryBasicExample [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryMultiRegionExample [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithCustomUpstreamExample [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithDockerExample [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteExample [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryVirtualExample [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryVulnerabilityScanningExample [Debug log]
TestAccArtifactRegistryRepository_cleanup [Debug log]
TestAccArtifactRegistryRepository_createMvnRelease [Debug log]
TestAccArtifactRegistryRepository_remote [Debug log]
TestAccAssuredWorkloadsWorkload_BasicHandWritten [Debug log]
TestAccAssuredWorkloadsWorkload_FullHandWritten [Debug log]
TestAccBigqueryConnectionConnectionIamPolicyGenerated [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionAwsExample [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionAwsUpdate [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionCloudspannerDataboostExample [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionCloudspannerExample [Debug log]
TestAccDataSourceApphubDiscoveredService_basic [Debug log]
TestAccDataSourceArtifactRegistryPackage_basic [Debug log]
TestAccDataSourceArtifactRegistryPackages_basic [Debug log]
TestAccDataSourceArtifactRegistryTags_basic [Debug log]
TestAccDataSourceArtifactRegistryVersion_basic [Debug log]
TestAccDataSourceArtifactRegistryVersions_basic [Debug log]
TestAccDataSourceGoogleArtifactRegistryLocations_basic [Debug log]
TestAccDataSourceGoogleArtifactRegistryRepositoryConfig [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlanAssociation_MultiRegion [Debug log]
TestAccDataSourceGoogleBackupDRDataSourceReference_MultiRegion [Debug log]
TestAccDataSourceGoogleBackupDRDataSourceReference_basic [Debug log]
TestAccDataformConfig_update [Debug log]
TestAccDataplexEntryLink_update [Debug log]
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccDataplexEntryLink_dataplexEntryLinkWithAspectExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 10, 2026
@github-actions
Copy link

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/dataplex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants