Stopping use of timer based cleanup logic for MRD #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek10004
added
execute-perf-test
kislaykishore
requested review from
a team,
gargnitingoogle and
BrennaEpp
and removed request for
a team,
gargnitingoogle and
BrennaEpp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2931 +/- ##
==========================================
- Coverage 75.66% 75.52% -0.15%
==========================================
Files 125 125
Lines 17641 17652 +11
==========================================
- Hits 13348 13331 -17
- Misses 3732 3759 +27
- Partials 561 562 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
abhishek10004
changed the title
vadlakondaswetha
approved these changes
Jan 27, 2025
ashmeenkaur
pushed a commit
that referenced
this pull request
Jan 27, 2025
Stopping use of timer based cleanup logic for MRD. Have minimized code changes so that reverting change back is easy.
meet2mky
pushed a commit
that referenced
this pull request
Jan 27, 2025
Stopping use of timer based cleanup logic for MRD. Have minimized code changes so that reverting change back is easy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making changes to stop using timer based cleanup function for MRD (Created b/391508479 to track restoring it).
Making this change against b/388177094