-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(modelarmor): Added samples for get and update floor settings #3095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(modelarmor): Added samples for get and update floor settings #3095
Conversation
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as an SME from the Model Armor team.
…oss folder, organization and project settings
Necessary permissions on the project have been added which resolved some of the issues. But it is still failing with permission issues on the organization and folder. Please pull in a modelarmor SME to help with this and lmk if we need to add anything to the CI. |
@purva9413 - I've already assigned the relevant IAM permissions to the org and folder used by tests. Also, all tests are passing on my local. It seems like there’s something missing on the CI side. Could you please confirm whether the following service account is being utilised for executing the tests? --> kokoro-trampoline@cloud-devrel-kokoro-resources.iam.gserviceaccount.com |
Not sure if something was done on the backend but the permission issue on the org and folder which I mentioned earlier has gone away? We see genuine test failures on Windows now.
|
@purva9413 I debugged and fixed the permission issues for folder and org. Could you add kokoro labels to verify? |
@purva9413 All tests are successful now! Are we good to merge this PR? |
Thanks for the approvals! Can someone trigger merge on this PR? |
6bad67d
@Anu4396 @purva9413 Could you please re-approve and trigger merge on this PR? A merge conflict was detected due to some change committed repo-wise in csproj files (https://github.com/GoogleCloudPlatform/dotnet-docs-samples/blob/main/modelarmor/api/ModelArmor.Samples.Tests/ModelArmor.Samples.Tests.csproj) 4 hours ago TIA! |
Added Model Armor Snippets for:
NOTE: Please set following environment variables required for running tests:
MA_FOLDER_ID:
695279264361
MA_ORG_ID:
951890214235