Skip to content

fix proxy URL #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix proxy URL #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ which authenticates itself with the Kubernetes API and proxies requests from you
[Pipeline] echo
To access your environment run `kubectl proxy`
[Pipeline] echo
Then access your service via http://localhost:8001/api/v1/proxy/namespaces/new-feature/services/gceme-frontend:80/
Then access your service via http://localhost:8001/api/v1/namespaces/new-feature/services/gceme-frontend:80/proxy/
[Pipeline] }
```

Expand All @@ -484,7 +484,7 @@ which authenticates itself with the Kubernetes API and proxies requests from you
1. Return to the original shell, and access your application via localhost:

```shell
$ curl http://localhost:8001/api/v1/proxy/namespaces/new-feature/services/gceme-frontend:80/
$ curl http://localhost:8001/api/v1/namespaces/new-feature/services/gceme-frontend:80/proxy/
```

1. You can now push code to the `new-feature` branch in order to update your development environment.
Expand Down
2 changes: 1 addition & 1 deletion sample-app/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ spec:
sh("kubectl --namespace=${env.BRANCH_NAME} apply -f k8s/services/")
sh("kubectl --namespace=${env.BRANCH_NAME} apply -f k8s/dev/")
echo 'To access your environment run `kubectl proxy`'
echo "Then access your service via http://localhost:8001/api/v1/proxy/namespaces/${env.BRANCH_NAME}/services/${feSvcName}:80/"
echo "Then access your service via http://localhost:8001/api/v1/namespaces/${env.BRANCH_NAME}/services/${feSvcName}:80/proxy/"
}
}
}
Expand Down