Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fixed inefficiency in the findRootCause method #2400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shawabhijit
Copy link

The fix improves efficiency by:

Adding a null/empty check to handle edge cases gracefully
Still using the first path to create the initial set of coordinates
Using Guava's Sets.intersection() method instead of repeated retainAll() calls
This creates new intersection sets rather than modifying the original set in-place
The result is a more efficient implementation that scales better with larger numbers of dependency paths and larger sets

Copy link

google-cla bot commented Mar 21, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@shawabhijit
Copy link
Author

Fixed inefficiency using Guava's sets utility for more efficient intersection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant