Respect snapshotTimeMillis when doing optimized count #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/gcbrun |
Member
|
Please run |
Member
|
/gcbrun |
|
@davidrabinowitz looks like there was an issue with using Optional<>.isEmpty because of the Java version. Are you able to /gcbrun again? |
Member
|
/gcbrun |
Member
|
/gcbrun |
Contributor
Author
|
@davidrabinowitz realise this never actually got merged, have updated to fix conflicts with latest |
Member
|
/gcbrun |
Member
|
Thanks for the update! Can you please verify that the tests (unit + integration) pass? |
Member
|
/gcbrun |
davidrabinowitz
approved these changes
Apr 28, 2025
Member
|
/gcbrun |
davidrabinowitz
requested changes
Apr 28, 2025
Member
davidrabinowitz
left a comment
davidrabinowitz
left a comment
There was a problem hiding this comment.
Please review the following test:
Step #2 - "unit-tests": [ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.848 s <<< FAILURE! -- in com.google.cloud.bigquery.connector.common.ReadSessionCreatorTest
Step #2 - "unit-tests": [ERROR] com.google.cloud.bigquery.connector.common.ReadSessionCreatorTest.testViewSnapshotTimeMillis -- Time elapsed: 0.011 s <<< ERROR!
Step #2 - "unit-tests": java.lang.NullPointerException
Step #2 - "unit-tests": at com.google.cloud.bigquery.connector.common.ReadSessionCreator.create(ReadSessionCreator.java:105)
Step #2 - "unit-tests": at com.google.cloud.bigquery.connector.common.ReadSessionCreatorTest.testViewSnapshotTimeMillis(ReadSessionCreatorTest.java:353)
Step #2 - "unit-tests": at ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are there existing ETE tests where it would make sense to include something for this
snapshotTimeMillis?