Refactor for BigQueryPartition class #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed table is expired and no longer accessible.
…rom time to time, the pipeline should be able to recover reading from the beginning of the split or the last checkpointed offset
|
/gcbrun |
...ctor-bigquery/src/main/java/com/google/cloud/flink/bigquery/services/TablePartitionInfo.java
Show resolved
Hide resolved
...r-bigquery/src/main/java/com/google/cloud/flink/bigquery/common/utils/BigQueryPartition.java
Outdated
Show resolved
Hide resolved
...gquery/src/test/java/com/google/cloud/flink/bigquery/common/utils/BigQueryPartitionTest.java
Outdated
Show resolved
Hide resolved
|
/gcbrun |
...uery/src/main/java/com/google/cloud/flink/bigquery/table/restrictions/BigQueryPartition.java
Show resolved
Hide resolved
...uery/src/main/java/com/google/cloud/flink/bigquery/table/restrictions/BigQueryPartition.java
Outdated
Show resolved
Hide resolved
...uery/src/main/java/com/google/cloud/flink/bigquery/table/restrictions/BigQueryPartition.java
Outdated
Show resolved
Hide resolved
...uery/src/main/java/com/google/cloud/flink/bigquery/table/restrictions/BigQueryPartition.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/google/cloud/flink/bigquery/table/restrictions/BigQueryPartitionTest.java
Outdated
Show resolved
Hide resolved
| BigQueryPartition.formatPartitionRestrictionBasedOnInfo( | ||
| Optional.of(info), "event", "2010-10-10")) | ||
| .isEqualTo("event BETWEEN '2010-10' AND '2010-11'"); | ||
| public void testCheckPartitionCompletedMonth() { |
There was a problem hiding this comment.
We should add edge case tests for February as leap month, non-leap month, a 30 day month, a 31 day month.
There was a problem hiding this comment.
Please add not completed 31 day month case. LGTM otherwise.
.../src/test/java/com/google/cloud/flink/bigquery/table/restrictions/BigQueryPartitionTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/google/cloud/flink/bigquery/table/restrictions/BigQueryPartitionTest.java
Show resolved
Hide resolved
|
/gcbrun |
|
/gcbrun |
vishalkarve15
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the unbounded source implementation. Test coverage for partition related methods was improved as well.