Event: add cover #45
Merged
Event: add cover #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkdamian
reviewed
Feb 2, 2023
| // const event = await Event.create(payload) | ||
| if (cover) { | ||
| event.cover = Attachment.fromFile(cover) | ||
| await cover.move(Application.tmpPath('uploads')) |
There was a problem hiding this comment.
cover.move funktioniert glaube nicht, so richtig erklären kann ich mir das aber nicht. tmpPath kommt dann '/var/folders/6c/szt79xt57dqfc35m33g6p3380000gp/T/cldn6wa690001jmkf5i7l4qa0'das nicht richtig ist. ich habe das in einer anderen func getestet und da kommt bei Application.tmpPath('uploads')der richtige path.
´Attachment.fromFile(cover)`macht aber schon alles, also das bild wird im tmpPath gespeichert.
hulkoba
force-pushed
the
event/add-cover
branch
from
d013e85 to
cb868f3
Compare
hulkoba
commented
Feb 6, 2023
| await event.merge(payload).save() | ||
|
|
||
| const { cover } = await request.validate(CoverUploadValidator) | ||
| event.cover = cover ? Attachment.fromFile(cover) : null |
There was a problem hiding this comment.
Eigentlich sollte das nicht nötig sein, wenn im Validator nur nullable steht. Aber Das ist vielleicht noch nicht ganz ausgereift
hulkoba
commented
Feb 6, 2023
Comment on lines
+246
to
+268
| // TODO: this does not work | ||
| // test('not allowed to override the event creator email', async ({ client, assert }) => { | ||
| // await EventFactory.create() | ||
| // const allEvents = await client.get('/_api/events') | ||
| // const { id, createEmail } = allEvents.body().events[0] | ||
|
|
||
| // const userRole = await Role.findByOrFail('name', roles.USER) | ||
| // const creator = await UserFactory.merge({ | ||
| // roleId: userRole.id, | ||
| // }).create() | ||
|
|
||
| // const requestBody = { | ||
| // creator_email: creator.email, | ||
| // } | ||
| // const response = await client.put(`/_api/events/${id}`).withCsrfToken().json(requestBody) | ||
|
|
||
| // assert.isTrue(response.body().success) | ||
| // assert.equal(response.body().event.create_email, createEmail) | ||
| // }) | ||
|
|
||
| /* | ||
| * DELETE Events | ||
| */ |
There was a problem hiding this comment.
Wenn die Roles ready sind, müssen wir hier noch mehr Tests schreiben
fix(event): upload event cover feat(event): validate cover
hulkoba
force-pushed
the
event/add-cover
branch
from
cb868f3 to
ceb3756
Compare
test(event): fix dates
tkdamian
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist
Screenshots
Related Issues or Pull Requests
closes #34
closes #36