Skip to content

Return empty array instead of null #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

Return empty array instead of null #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion addons/godot-firebase/firestore/firestore.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ func query(query : FirestoreQuery) -> Array:
task._fields = JSON.stringify(body)
task._url = url
_pooled_request(task)
return await _handle_task_finished(task)
var result = await _handle_task_finished(task)
return result if result != null else []


## Request a list of contents (documents and/or collections) inside a collection, specified by its [i]id[/i]. This method will return a [code]FirestoreTask[/code] object, representing a reference to the request issued. If saved into a variable, the [code]FirestoreTask[/code] object can be used to yield checked the [code]result_query(result)[/code] signal, or the more generic [code]task_finished(result)[/code] signal.
Expand Down
6 changes: 3 additions & 3 deletions tests/firestore/firestore.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,10 @@ func _test_firestore() -> void:
## Query Collection
_print_to_console("\nRunning Firestore Query")
var query : FirestoreQuery = FirestoreQuery.new()
query.from("Firebasetester")
query.where("points", FirestoreQuery.OPERATOR.GREATER_THAN, 5)
query.from("Firebasetester", false)
query.order_by("points", FirestoreQuery.DIRECTION.DESCENDING)
query.limit(10)
query.where("points", FirestoreQuery.OPERATOR.GREATER_THAN, 5)
query.limit(1)
var result = await Firebase.Firestore.query(query)
_print_to_console(result)
$run_query.button_pressed = true
Expand Down