add convenience methods for common Git trailers #2030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphmodales
force-pushed
the
trailer-conviences
branch
2 times, most recently
from
bbab7b2 to
55ddac4
Compare
Byron
approved these changes
May 28, 2025
There was a problem hiding this comment.
Thanks a lot, much appreciated.
Please note that I put a refactor on top that essentially removed the Vec<_> portions of the API.
Something one could consider adding is a way to parse the authors as actual gix_actor::Identity for even more convenience. There it would make sense to return Result<Vec<_>, _>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements convenient methods for extracting commit authors from trailers as suggested in issue #1804.
The main changes are adding case-insensitive detection methods to TrailerRef for common trailer types like signed-off-by and co-authored-by, along with filtering methods on the Trailers iterator and high-level convenience methods on CommitRef to easily extract all authors from squashed commits that contain multiple contributors.