-
-
Notifications
You must be signed in to change notification settings - Fork 341
build(deps): bump zip from 2.2.3 to 2.3.0 in the cargo group across 1 directory #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the symlink traversal vulnerability CVE-2025-29787 in the zip
dependency. I believe it does not yet have a RUSTSEC advisory, which is why cargo deny advisories
has not yet said anything. For software that uses zip
in an affected way, it's fairly serious. Fortunately, it looks like we are only using it to create archives, and not to extract them:
> git grep -En 'use.*[^.]\bzip\b|\bzip::'
gix-archive/src/write.rs:135: let mut ar = zip::write::ZipWriter::new(out);
gix-archive/src/write.rs:140: let mtime = zip::DateTime::from_date_and_time(
gix-archive/src/write.rs:172: ar: &mut zip::write::ZipWriter<W>,
gix-archive/src/write.rs:175: mtime: zip::DateTime,
gix-archive/src/write.rs:179: let file_opts = zip::write::FileOptions::<'_, ()>::default()
gix-archive/src/write.rs:180: .compression_method(zip::CompressionMethod::Deflated)
gix-archive/tests/archive.rs:174: let mut ar = zip::ZipArchive::new(std::io::Cursor::new(buf.as_slice()))?;
If I am right about that, then we don't need to release new binaries for the updated dependency. Either way, I think it's a good idea to take this update now--then it won't be a concern when using a --locked
build or in cargo deny
.
@dependabot rebase |
@dependabot merge |
Bumps the cargo group with 1 update in the / directory: [zip](https://github.com/zip-rs/zip2). Updates `zip` from 2.2.3 to 2.3.0 - [Release notes](https://github.com/zip-rs/zip2/releases) - [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md) - [Commits](zip-rs/zip2@v2.2.3...v2.3.0) --- updated-dependencies: - dependency-name: zip dependency-type: direct:production dependency-group: cargo ... Signed-off-by: dependabot[bot] <[email protected]>
ea7ff1d
to
00d1a00
Compare
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
The failure is due to #1816, which causes that test to fail intermittently. I'll rerun that whole workflow just to be safe. |
@dependabot merge |
Bumps the cargo group with 1 update in the / directory: zip.
Updates
zip
from 2.2.3 to 2.3.0Release notes
Sourced from zip's releases.
Changelog
Sourced from zip's changelog.
Commits
6eab5f5
chore: release v2.3.0 (#300)e4aee20
implementZipFile::options
+ refactor options normalization (#305)ea8a7bb
fix(test): Conditionalize a zip64 doctest (#308)365c81a
Usexz2
crate instead of a custom implementation (#306)ae94b34
chore: Fix clippy and cargo fmt warnings (#310)a2e062f
Merge commit from fork0199ac2
Simplify handling for symlink targets977bb94
fix failing tests, remove symlink loop check3cb29e7
Partial fix for tests2182b07
RefactorDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @EliahKagan.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.