Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1780
Fixes #1866
This changes
ubuntu-22.04-arm
back toubuntu-24.04-arm
both in thetest-fast
ARM job and thetest-32bit
ARM job, because the underlying cause of the problems that we changed them to 22.04 to avoid (rust-lang/rust#135867) have been fixed to the extent that they affect GitHub Actions runners. See #1866 for details on that, or actions/partner-runner-images#36 (comment) for a quick summary of the underlying fix.The first commit here includes a heavy test, running hundreds of matrix jobs, to confirm the above and look for any remaining problems with
ubuntu-24.04-arm
before switching back to it. The second commit removes the separate workflow for those tests, since we should not run these extra jobs regularly, and since if they are ever useful again then future tests would still need to modify them significantly.The heavy-test workflow runs, where the first run didn't have
fail-fast: false
ontest-32bit
, were:Enough test jobs were run that failures were to be expected: even outside of ARM runners, there is a low but nonzero rate of nondeterministic failure in gitoxide CI. The failures I observed were as follows:
In test-fast on 24.04, in one of the runs that tested a modified tool installation procedure using
cargo quickinstall
, downloading failed with HTTP 403 including after retries.In test-32bit on 22.04,
gix-prompt::prompt ask::askpass_only
failed with EOF on this sub-case. I vaguely recall seeing similar failures in these expectrl-based tests, very rarely. But I am not sure. In any case, this is with 22.04, not 24.04.In test-fast on 22.04,
gix-worktree-state-tests::worktree state::checkout::dangling_symlinks_can_be_created
failed because the probe did not detect the ability to create symlinks. This is due to #1816. It makes the third known occurrence, after #1789 and #1816 (comment). It is interesting because the first two occurrences were instead withgix-worktree-state-tests::worktree state::checkout::overwriting_files_and_lone_directories_works
instead.In test-32bit on 22.04,
gix-status-tests::status index_as_worktree_with_renames::changed_and_untracked_and_renamed
failed. Examining the actual vs. expected diffs reveals that it is due to #1832:These are four failures in hundreds of runs. Only one of the four failures is on 24.04, with a download procedure that we do not use outside of these tests and the experiments that precede them (
ci.yml
does not usecargo quickinstall
) and that I beleive I have seen locally a number of times on different platforms. The other three failures were on 22.04, all of them look like they are not runner-specific in any way, and none of them resemble any of the failures that had motivated us to avoidubuntu-24.04-arm
before.