-
Notifications
You must be signed in to change notification settings - Fork 4k
Make sure to use the correct version for adaptive content #3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
I've spent way too much time trying to understand what's going on here. It's not perfect, but this PR should allow us to be safe and have a good enough client cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the approach makes sense, it forces us to have ugly URls and also to handle ALL urls everywhere.
Can we instead have an effect like:
React.useEffect(() => {
next.clearRouterCacheSomehow();
}, [cacheContextKey]);
?
One thing with it right now, for unsigned claims using a |
Use contextId from
PublishedContentSite
to force refresh RSC data based on it.When the claims change, the whole RSC data would get refreshed.