Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restrict auth_config file permissions #1054

Merged

Conversation

salome-voltz
Copy link
Collaborator

Context

File auth_config.yaml contains sensitive information, but had group and world read permission.

This MR restricts the file's permission to user-ony read/write permissions.

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.76%. Comparing base (07ec91f) to head (8eaee75).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1054   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         143      143           
  Lines        6048     6050    +2     
=======================================
+ Hits         5550     5552    +2     
  Misses        498      498           
Flag Coverage Δ
unittests 91.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salome-voltz salome-voltz marked this pull request as ready for review February 5, 2025 13:17
@salome-voltz salome-voltz requested a review from a team as a code owner February 5, 2025 13:17
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remarks.

ggshield/core/config/utils.py Outdated Show resolved Hide resolved
@salome-voltz salome-voltz force-pushed the salomevoltz/scrt-5312-change-auth_config-file-permissions branch from 7e20611 to 8eaee75 Compare February 5, 2025 13:47
@salome-voltz salome-voltz merged commit 920bbf7 into main Feb 5, 2025
32 checks passed
@salome-voltz salome-voltz deleted the salomevoltz/scrt-5312-change-auth_config-file-permissions branch February 5, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants