Pre-commit fixes #1047
Merged
Pre-commit fixes #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import-linter-config hook fails on Windows because calling a shell script with `pdm run the_script` does not work on Windows: the shebang is not taken into account. Using `pdm run bash -c the_script` fix that, but then it fails because the script itself calls ./scripts/generate-import-linter-config.py, but it does not call it with the correct Python interpreter. To fix that, call check-import-linter-config.sh without pdm, and make it use `pdm run` to call generate-import-linter-config.py.
This avoids CRLF vs LF issues on Windows.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1047 +/- ##
==========================================
+ Coverage 92.08% 92.10% +0.01%
==========================================
Files 181 181
Lines 7762 7762
==========================================
+ Hits 7148 7149 +1
+ Misses 614 613 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
salome-voltz
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done
This PR makes a few fixes in our pre-commit config:
pre-commit autoupdate(required one fix for a new error found by flake8).Validation
pre-commit run -a, on Windows.PR check list
skip-changeloglabel has been added to the PR.