Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmd): improve the exit-zero option help message #1041

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

gg-jonathangriffe
Copy link
Contributor

Context

The help message for the exit-zero option can be slightly misleading, as one could understand that it will make the command exit with the 0 exit code, regardless of the error raised.

What has been done

The exit-zero option help message was modified to make it clear it only applies when a secret is detected.

@gg-jonathangriffe gg-jonathangriffe self-assigned this Jan 6, 2025
@gg-jonathangriffe gg-jonathangriffe requested a review from a team as a code owner January 6, 2025 15:32
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (7d85eb1) to head (4ae2c58).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1041      +/-   ##
==========================================
- Coverage   92.09%   91.86%   -0.24%     
==========================================
  Files         181      181              
  Lines        7755     7755              
==========================================
- Hits         7142     7124      -18     
- Misses        613      631      +18     
Flag Coverage Δ
unittests 91.86% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mathieubellon mathieubellon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sevbch

@agateau-gg agateau-gg merged commit 276a186 into main Jan 9, 2025
32 of 34 checks passed
@agateau-gg agateau-gg deleted the jgriffe/improve-exit-zero-help-msg branch January 9, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants