chore: remove SCA & IaC

[FlorianPerucki]

Remove SCA & IaC commands and related code

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (28f5153) to head (58782e1).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
- Coverage   92.10%   91.75%   -0.35%     
==========================================
  Files         181      143      -38     
  Lines        7762     6040    -1722     
==========================================
- Hits         7149     5542    -1607     
+ Misses        613      498     -115     

Flag	Coverage Δ
unittests	91.75% <100.00%> (-0.35%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[salome-voltz]

This is a first pass (the PR is a bit massive 😅 ) but I have found some dead code that should be removed. Also, If I understand correctly the scan mode "DIFF" is directly related to IaC scan so it might be worth looking into it to check if we can also remove it :)

[salome-voltz]

Sorry, I should have done that in my first review, I ran a static code analysis tool (deadcode) over the project. Here is the dead code related to SCA/IaC that I found :

• display_beta_warning in ggshield/cmd/utils/common_decorators.py
• class ConfigIgnoredElement in ggshield/core/config/user_config.py
• variable REMOVED in Enum IncidentStatus in ggshield/core/constants.py
• class NotAMergeRequestError in ggshield/core/errors.py
• file_diff_info in ggshield/core/text_utils.py
• get_diff_files_status in ggshield/utils/git_shell.py

I wasn't sure if we should keep the code that could be useful in the future, but after discussing the matter with Aurélien, "throw away every code you can" is the project's policy.

Apart from these, the PR looks good to me! Thank you for the tedious work!

[FlorianPerucki]

Thank you @salome-voltz! In addition to your list I have also removed get_commits_not_in_branch