Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete instances only if not deleted earlier #452

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Delete instances only if not deleted earlier #452

wants to merge 2 commits into from

Conversation

LKajan
Copy link
Contributor

@LKajan LKajan commented Feb 19, 2025 •
edited
Loading

Contains 2 commits:

  • First just refactors to use common fixture.
  • Second fixes the actual issue. Check if the instance is still in session before trying to delete it. It might be deleted before in tests.

@LKajan LKajan requested a review from Rikuoja February 19, 2025 09:48
@LKajan LKajan force-pushed the refactor-test-fixtures branch from cd244cd to 51f2e82 Compare February 19, 2025 12:20
@LKajan LKajan force-pushed the refactor-test-fixtures branch from 51f2e82 to 3436353 Compare February 19, 2025 12:26
@LKajan LKajan mentioned this pull request Feb 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rikuoja Rikuoja Awaiting requested review from Rikuoja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LKajan