Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Add max and min limits to form values #1915

Merged

Conversation

ali-ichk
Copy link
Contributor

@ali-ichk ali-ichk commented Mar 5, 2025

Description

Came from this forum request: https://ask.gibbonedu.org/t/how-to-restrict-numeric-input-range/15191

Fixed the bug to change the input type to "number" and add a max and min value limit

Copy link
Member

@SKuipers SKuipers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ali, I'm going to merge and test.

@SKuipers SKuipers merged commit d7d1690 into GibbonEdu:v29.0.00 Mar 6, 2025
5 checks passed
SKuipers pushed a commit that referenced this pull request Mar 6, 2025
@AndroidOL
Copy link

Reporting an issue: If only the maximum or minimum value is defined, an HTML error occurs. Please use double quotes to properly close the attribute.

Number.template.php:

min="<?= $min; ?>" max="<?= $max; ?>"

@ali-ichk
Copy link
Contributor Author

ali-ichk commented Mar 9, 2025

@AndroidOL Thanks for your comments. It is really helpful and will apply the relevant fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants