Skip to content

Commit

Permalink
System: fixed column order of Export to Excel option on Staff Dashboard
Browse files Browse the repository at this point in the history
  • Loading branch information
SKuipers committed Mar 14, 2022
1 parent 57ce415 commit e3c826b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.txt
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@ v24.0.00
System: improved display of IDD country codes in phone number entry field
System: fixed SQL errors in the User Status Check & Fix CLI script
System: fixed Google OAuth not correctly handling empty refresh tokens
System: fixed column order of Export to Excel option on Staff Dashboard
Attendance: fixed non-attendance classes showing up in Set Future Absence
Finance: fixed HTML being removed from notes on invoices
Markbook: fixed rubrics not displaying in Enter Data page for large classes
Markbook: fixed rubrics not displaying for large classes in Enter Data page
Messenger: fixed PHP 8+ error when sending messages to Class target
Planner: fixed invalid values in homeworkSubmissionDrafts in PHP 8+
System Admin: fixed HTML being stripped out of the privacy policy
Expand Down
6 changes: 3 additions & 3 deletions src/Gibbon/Excel.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function exportWithQuery($result, $excel_file_name)
if ($rNum === 1)
{
// Row 1 is the headers.
$cNum = -1;
$cNum = 0;
foreach($row as $name=>$value )
{
$cNum++ ;
Expand All @@ -60,10 +60,10 @@ function exportWithQuery($result, $excel_file_name)
$this->getActiveSheet()->getStyle('1:1')->getFont()->setBold(true);
$rNum++;
}
$cNum = -1 ;
$cNum = 0;
foreach($row as $value )
{
$cNum++ ;
$cNum++;
$this->getActiveSheet()->setCellValueByColumnAndRow($cNum, $rNum, $value);
}
}
Expand Down

0 comments on commit e3c826b

Please sign in to comment.