Crowd Assessment: fixed PHP query error for empty result sets

GibbonEdu · Mar 3, 2025 · 8c9b888 · 8c9b888
1 parent afb6ad8
commit 8c9b888
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/modules/Crowd Assessment/crowdAssess.php b/modules/Crowd Assessment/crowdAssess.php
@@ -33,6 +33,8 @@
     $page->breadcrumbs->add(__('View All Assessments'));
 
     $sql = getLessons($guid, $connection2);
+    if (empty($sql[0]) || empty($sql[1])) return;
+
     $lessons = $pdo->select($sql[1], $sql[0])->fetchAll();
     $unitGateway = $container->get(UnitGateway::class);
 

diff --git a/modules/Crowd Assessment/crowdAssess_view.php b/modules/Crowd Assessment/crowdAssess_view.php
@@ -46,6 +46,9 @@
     // Check existence of and access to this lesson.
     $and = " AND gibbonPlannerEntryID=$gibbonPlannerEntryID";
     $sql = getLessons($guid, $connection2, $and);
+
+    if (empty($sql[0]) || empty($sql[1])) return;
+
     $lesson = $pdo->select($sql[1], $sql[0])->fetch();
 
     if (empty($lesson)) {
@@ -73,6 +76,8 @@
     $sqlList = getStudents($guid, $connection2, $role, $lesson['gibbonCourseClassID'], $lesson['homeworkCrowdAssessOtherTeachersRead'], $lesson['homeworkCrowdAssessOtherParentsRead'], $lesson['homeworkCrowdAssessSubmitterParentsRead'], $lesson['homeworkCrowdAssessClassmatesParentsRead'], $lesson['homeworkCrowdAssessOtherStudentsRead'], $lesson['homeworkCrowdAssessClassmatesRead']);
 
     // DATA TABLE
+    if (empty($sqlList[0]) || empty($sqlList[1])) return;
+
     $students = $pdo->select($sqlList[1], $sqlList[0])->fetchAll();
     foreach ($students as $index => $student) {
         $homework = $plannerHomeworkGateway->selectBy(['gibbonPlannerEntryID' => $gibbonPlannerEntryID, 'gibbonPersonID' => $student['gibbonPersonID']])->fetch();