PKINIT Authentication Minor Improvements #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was formed from the troubleshooting on #196
The main reason for this PR is to include fix an issue we have where Windows Server 2025 Domain Controllers reply with two PA_DATA structures (ETYPE-INFO2 and PK-AS-REP) and Rubeus only expects a single structure and the first option is always ETYP-INFO2 meaning that the TGT request is successful but an error occurs when forming the AS-REP.
The other changes are exetremely minor and were made to get Wireshark to show better data when decoding: