Repository navigation
feat(verify): gate new-device candidates before device_catalog - #123
Merged
Merged
Conversation
…alog python -m app.verify candidates <rows.jsonl> --out <decisions.jsonl> runs Play new-device rows through staged checks (junk, seller, label, dup, in-batch) against the dataset and marks each accept or hold with reasons. Brand-level shares (non-mobile Console rows, rows naming another brand) catch TV vendors and ODMs that per-row rules miss; ids are matched across all brands including variant.model_numbers. Refs #98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
python -m app.verify candidates. It is a staged accept/hold gate for new-device rows, here the Google Play hold queue from ADR-016, applied before they becomedevice_catalogentries.Stages:
modelswhen present), codename echo, non-Latin script, bare model codes for major brands, internal strings.variant.model_numbers;Nothing is dropped; held rows keep their reasons for review. Unit tests are in
tests/verify/test_catalog_candidates.py.Refs #98