fix(verify): keep the query in URL dedupe and cache every citation of a checked page - #105
Merged
Merged
Conversation
… a checked page dedupe_urls keyed on host and path only, so cpubenchmark.net/cpu.php?cpu=X pages collapsed into one representative and 762 green CPUs never had their own citation checked. Pages cited under different #fragments were checked once, but the verdict was cached only under the representative URL, which promotion looks up by exact URL. The key now includes the query, and each result is stored for every citation of the same resource. Refs #98 Refs GetTechAPI/TechAPI#297
This was referenced Sep 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two check-urls bugs kept green records from ever being promoted:
dedupe_urlskeyed on host + path, socpubenchmark.net/cpu.php?cpu=Xcitations (distinct pages) collapsed into one representative. 762 green CPUs never had their own citation checked.#fragmentswere checked once, but the verdict was cached only under the representative URL. Promotion looks citations up by exact URL, so the other fragments stayed "unchecked" (about 60 GPUs and SoCs citing Wikipedia list sections).Fix: the dedupe key includes the query (the fragment is still ignored), and each result is written for every citation of the same resource. A test covers the dedupe key (query kept, fragment ignored).
Validation: ruff, mypy, full pytest.
Refs #98
Refs GetTechAPI/TechAPI#297