Skip to content

data(brand): real descriptions for recognizable brands - #45

Merged
Seungpyo1007 merged 2 commits into
mainfrom
data/brand-descriptions
Jun 21, 2026
Merged

Seungpyo1007 merged 2 commits into
mainfrom
data/brand-descriptions

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

Summary

Replace the generic placeholder brand descriptions ("Phone brand observed in the GSMArena mobile devices dataset…") with real, factual EN + KO descriptions for 53 recognizable brands (Sony Ericsson, Palm, Vodafone, Orange, O2, Casio, Dell, HP, Amazon, T-Mobile, Bosch, Haier, Sagem, Sonim, Telit, Thuraya, Benefon, Qtek, E-TEN, MiTAC, Karbonn, Intex, verykool, Yezz, …).

Changes

  • 53 data/brand/**/*.json: real description_en + description_ko (replacing the placeholder + filling the missing Korean field).
  • 53 matching site/public/v1/brands/<slug>/index.json dump details refreshed (descriptions are verbatim passthrough, so the dump matches a full regenerate).
  • 7 genuinely-obscure brands (Chea, XCute, MWg, Parla, NIU, WND, …) intentionally keep their provenance placeholder — no fabricated facts.
  • Descriptions are conservative (region/segment) for unaudited brands (verified: false); audit can refine later.

Verification

  • python -m app.validate PASS
  • python TechEngine/integrity_check.py data --strict PASS
  • git diff --check origin/main...HEAD PASS
  • Local site build skipped (isolated worktree has no node_modules); change is build-safe description text and the TechEngine homepage validation builds the site.

Closes #1

Replace generic placeholder descriptions with factual EN/KO descriptions for 53 well-known brands (Sony Ericsson, Palm, Vodafone, Casio, Dell, HP, etc.). Obscure brands keep their provenance placeholder to avoid fabrication.

Refs #1
@Seungpyo1007 Seungpyo1007 added the data Dataset changes label Jun 21, 2026
@Seungpyo1007 Seungpyo1007 self-assigned this Jun 21, 2026
@github-actions github-actions Bot added the enhancement New feature or request label Jun 21, 2026
@Seungpyo1007 Seungpyo1007 moved this from Todo to In Progress in TechAPI-Project Jun 21, 2026
@Seungpyo1007
Seungpyo1007 merged commit 9449a70 into main Jun 21, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in TechAPI-Project Jun 21, 2026
@Seungpyo1007
Seungpyo1007 deleted the data/brand-descriptions branch August 3, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

TechAPI dataset roadmap and status: all categories (1989-2026)

1 participant