Skip to content

fix(data): backfill Wikipedia Commons images for 28 devices - #318

Merged
Seungpyo1007 merged 2 commits into
developfrom
feat/wikipedia-device-images
Sep 28, 2026
Merged

Seungpyo1007 merged 2 commits into
developfrom
feat/wikipedia-device-images

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

Backfill 28 freely licensed Commons photos for laptop, tablet, watch and PDA records that already cite Wikipedia and lack an image URL. The existing conservative image, model-filename and license filters were preserved; only the image URL, license and attribution fields were added.

Category Checked Accepted Rejected Logo/model/format rejection No image Bad license
laptop 44 12 32 18 14 0
monitor 0 0 0 0 0 0
tablet 48 11 37 24 13 0
watch 55 4 51 40 11 0
pda 16 1 15 12 2 1
Total 163 28 135 94 40 1

Ran the CLI from GetTechAPI/TechEngine#108 for each category:

python -m app.verify.wikipedia_image_backfill --data-root <TechAPI-worktree> --category <category> --include-missing-key --apply

The batches share the existing append-only data/_verify/state/wikipedia_image_cache.jsonl: all earlier rows were preserved and 163 decisions appended, keyed by repository-relative record paths. No network errors or incompatible-record skips occurred.

The final commit refreshes the affected collections through TechEngine's standard dump generator and preserves all other manifest entries. Exactly 28 detail pages changed, and each image URL was checked against its source record.

Validation:

  • Full-dataset python -m app.validate passed against this modified data.
  • python -m app.dump_check --base 2c2c152f2ba2 --base-ref develop passed across 12 categories and 191,837 records.
  • Image-only record diff and append-only cache audits passed; both worktrees are clean.
  • Tool validation: 23 focused tests, ruff and mypy passed locally; TechEngine CI passed all 534 tests with 77.62% coverage.

Closes #295

@github-actions github-actions Bot added bug Something isn't working data Dataset changes enhancement New feature or request labels Sep 28, 2026
@Seungpyo1007
Seungpyo1007 merged commit 3891e50 into develop Sep 28, 2026
5 checks passed
@Seungpyo1007
Seungpyo1007 deleted the feat/wikipedia-device-images branch September 30, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Data collection: new records (workstream)

1 participant