Remove six AMD GPUs imported with game-clock values - #262
Merged
Merged
Conversation
The Wikipedia RDNA/Polaris tables put game and boost clocks in one "Core / Clock (MHz)" cell, and some rows list only the game clock. The import read them as base == boost, so the Radeon Pro W7900 Dual Slot, W7800 48 GB, W6500M, WX 2100/3100 Mobile and RX 6300M records carried wrong clocks. The page gives no base clock, so drop them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #258. The Wikipedia RDNA and Polaris tables put game and boost clocks together in one "Core / Clock (MHz)" cell (W7900 Dual Slot:
1855 2495), and some rows list only the game clock (RX 6300M:1512). The import stored those values as base == boost. The existing W7900 record has base 1295 and boost 2495, which is how the mismatch surfaced (the cross-check in #260 caught it).The page gives no base clock for these boards, so this PR removes the six affected records rather than guessing:
amd/2024/enterprise/radeon-pro-w7900-dual-slotamd/2024/enterprise/radeon-pro-w7800-48gbamd/2022/enterprise/radeon-pro-w6500mamd/2022/consumer/radeon-rx-6300mamd/2017/enterprise/radeon-pro-wx-2100-mobileamd/2017/enterprise/radeon-pro-wx-3100-mobileThe parser fix is in GetTechAPI/TechEngine#91. The other 63 records from #258 are unaffected: NVIDIA rows have separate base and boost columns, and the ATI/FirePro/HD 5610 boards predate boost clocks.
Closes #1