Fix verified cross-reference data contradictions - #253
Merged
Merged
Conversation
Member
Author
|
Reverted two of the 17 corrections (INQ Chat 3G battery 1150→1500, HTC Jetstream resolution 1280x800→1280x768). In both cases the Wikipedia infobox disagrees with the record's original source (GSMArena-derived data: 1150 mAh, 1280x800), and HTC's own spec for the Jetstream is WXGA 1280x800. Since the sources conflict, the original values stay. The other 15 corrections are unambiguous (e.g. storage recorded as RAM, a 2007 release year on a 2017 phone) and remain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-reference contradiction review
Reviewed the last append-only entry per record in the crossref, smartphone, tablet, watch, and PDA caches against the matched Wikipedia or Wikidata page. Changed a value only where the page unambiguously describes that same device; preserved all
verifiedflags. The Pixel 2 XL record moved from the 2007 directory to the 2017 directory because the repository validator requires the path year to matchrelease_date.Unchanged (b) verdicts include Wikidata homonyms (for example MX as Tokyo MX), model collisions (Sendo M550 versus Eten M550), and family pages or memory variants. Unchanged (c) verdicts include SoC aliases, source disagreements for older Palm display sizes, and Wikipedia table parsing that treats storage as RAM (for example Samsung Gear's
4GB/512 MB RAM).Validation:
PYTHONIOENCODING=utf-8 python -m app.validatepassed. The dump was not run.Closes #1