Skip to content

fix(data): populate base_model_slug on 31,372 smartphone records - #247

Merged
Seungpyo1007 merged 191 commits into
developfrom
data/base-model-slug-fill
Sep 24, 2026
Merged

Seungpyo1007 merged 191 commits into
developfrom
data/base-model-slug-fill

Conversation

@Seungpyo1007

@Seungpyo1007 Seungpyo1007 commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Summary

TechPicks (reference-consumer app) reported its canonical flagship catalog had base_model_slug null on 100% of records, blocking variant-grouping. Of 93,396 smartphone records, 61,731 already had it (populated on bulk-imported derivative records grouped by physical device); the 31,665 gap was almost entirely the curated/flagship records that never got it computed.

  • 12,698 joined an existing same-brand group (12,688 exact slug match, 10 via known import-suffix stripping)
  • 18,674 self-referenced (their own slug, since no sibling group exists yet — mostly 2023-2026 flagships with no bulk-import sibling)
  • 293 left null on purpose: cross-brand slug collisions (287, e.g. flash exists under alcatel/dell/zte) or multiple same-brand candidate bases (6) — no guessing.

Test plan

  • python -m app.validate passed

Closes #1

@Seungpyo1007 Seungpyo1007 added enhancement New feature or request data Dataset changes labels Sep 24, 2026
@Seungpyo1007 Seungpyo1007 self-assigned this Sep 24, 2026
@github-actions github-actions Bot added the bug Something isn't working label Sep 24, 2026
@Seungpyo1007
Seungpyo1007 force-pushed the data/base-model-slug-fill branch from 9992aeb to f82af9b Compare September 24, 2026 22:46
@Seungpyo1007
Seungpyo1007 merged commit d91eee0 into develop Sep 24, 2026
5 checks passed
@Seungpyo1007
Seungpyo1007 deleted the data/base-model-slug-fill branch September 24, 2026 22:51
@github-project-automation github-project-automation Bot moved this from In Progress to Done in TechAPI-Project Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

TechAPI dataset roadmap and status: all categories (1989-2026)

1 participant