fix(data): populate base_model_slug on 31,372 smartphone records - #247
Merged
Merged
Conversation
Seungpyo1007
force-pushed
the
data/base-model-slug-fill
branch
from
September 24, 2026 22:46
9992aeb to
f82af9b
Compare
Merged
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TechPicks (reference-consumer app) reported its canonical flagship catalog had
base_model_slugnull on 100% of records, blocking variant-grouping. Of 93,396 smartphone records, 61,731 already had it (populated on bulk-imported derivative records grouped by physical device); the 31,665 gap was almost entirely the curated/flagship records that never got it computed.flashexists under alcatel/dell/zte) or multiple same-brand candidate bases (6) — no guessing.Test plan
python -m app.validatepassedCloses #1