Skip to content

fix(llc, samples): to run video on windows #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions dogfooding/linux/flutter/generated_plugin_registrant.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include <record_linux/record_linux_plugin.h>
#include <stream_webrtc_flutter/flutter_web_r_t_c_plugin.h>
#include <url_launcher_linux/url_launcher_plugin.h>
#include <volume_controller/volume_controller_plugin.h>

void fl_register_plugins(FlPluginRegistry* registry) {
g_autoptr(FlPluginRegistrar) desktop_drop_registrar =
Expand All @@ -37,7 +36,4 @@ void fl_register_plugins(FlPluginRegistry* registry) {
g_autoptr(FlPluginRegistrar) url_launcher_linux_registrar =
fl_plugin_registry_get_registrar_for_plugin(registry, "UrlLauncherPlugin");
url_launcher_plugin_register_with_registrar(url_launcher_linux_registrar);
g_autoptr(FlPluginRegistrar) volume_controller_registrar =
fl_plugin_registry_get_registrar_for_plugin(registry, "VolumeControllerPlugin");
volume_controller_plugin_register_with_registrar(volume_controller_registrar);
}
1 change: 0 additions & 1 deletion dogfooding/linux/flutter/generated_plugins.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ list(APPEND FLUTTER_PLUGIN_LIST
record_linux
stream_webrtc_flutter
url_launcher_linux
volume_controller
)

list(APPEND FLUTTER_FFI_PLUGIN_LIST
Expand Down
7 changes: 6 additions & 1 deletion dogfooding/windows/flutter/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ include(${EPHEMERAL_DIR}/generated_config.cmake)
# https://github.com/flutter/flutter/issues/57146.
set(WRAPPER_ROOT "${EPHEMERAL_DIR}/cpp_client_wrapper")

# Set fallback configurations for older versions of the flutter tool.
if (NOT DEFINED FLUTTER_TARGET_PLATFORM)
set(FLUTTER_TARGET_PLATFORM "windows-x64")
endif()

# === Flutter Library ===
set(FLUTTER_LIBRARY "${EPHEMERAL_DIR}/flutter_windows.dll")

Expand Down Expand Up @@ -92,7 +97,7 @@ add_custom_command(
COMMAND ${CMAKE_COMMAND} -E env
${FLUTTER_TOOL_ENVIRONMENT}
"${FLUTTER_ROOT}/packages/flutter_tools/bin/tool_backend.bat"
windows-x64 $<CONFIG>
${FLUTTER_TARGET_PLATFORM} $<CONFIG>
VERBATIM
)
add_custom_target(flutter_assemble DEPENDS
Expand Down
2 changes: 1 addition & 1 deletion dogfooding/windows/flutter/generated_plugins.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ list(APPEND FLUTTER_PLUGIN_LIST
media_kit_video
permission_handler_windows
record_windows
screen_brightness_windows
share_plus
stream_webrtc_flutter
thumblr_windows
url_launcher_windows
volume_controller
)

list(APPEND FLUTTER_FFI_PLUGIN_LIST
Expand Down
2 changes: 1 addition & 1 deletion melos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ command:
device_info_plus: ">=10.1.2 <12.0.0"
share_plus: ^11.0.0
stream_chat_flutter: ^9.8.0
stream_webrtc_flutter: ^1.0.9
stream_webrtc_flutter: ^1.0.10
stream_video: ^0.10.1
stream_video_flutter: ^0.10.1
stream_video_noise_cancellation: ^0.10.1
Expand Down
3 changes: 2 additions & 1 deletion packages/stream_video/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
* Deprecated `callRejoinTimeout` in `RetryConfig`, instead added `networkAvailabilityTimeout` to `CallPreferences` to control how long the SDK waits for network connectivity to be restored during reconnection attempts before timing out.

🐞 Fixed
* Sorting of participants after screen sharing stopped.s
* Sorting of participants after screen sharing stopped.
* Fixed `DtlsSrtpKeyAgreement` audio constraint parameter mapping

🔄 Dependency updates
* Updated `flutter_callkit_incoming` dependency to the latests (2.5.5) version. That version contains Android 14 compatibility fixes for ringing notifications and lock screen handling.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class AudioConstraints extends MediaConstraints {
{'googAutoGainControl': autoGainControl},
{'googHighpassFilter': highPassFilter},
{'googTypingNoiseDetection': typingNoiseDetection},
{'DtlsSrtpKeyAgreement': 'true'},
{'DtlsSrtpKeyAgreement': true},
];
}

Expand Down
2 changes: 1 addition & 1 deletion packages/stream_video/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ dependencies:
rxdart: ^0.28.0
sdp_transform: ^0.3.2
state_notifier: ^1.0.0
stream_webrtc_flutter: ^1.0.9
stream_webrtc_flutter: ^1.0.10
synchronized: ^3.1.0
system_info2: ^4.0.0
tart: ^0.5.1
Expand Down
2 changes: 1 addition & 1 deletion packages/stream_video_flutter/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ dependencies:
stream_video: ^0.10.1
stream_video_flutter: ^0.10.1
stream_video_push_notification: ^0.10.1
stream_webrtc_flutter: ^1.0.9
stream_webrtc_flutter: ^1.0.10

dependency_overrides:
stream_video:
Expand Down
2 changes: 1 addition & 1 deletion packages/stream_video_flutter/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dependencies:
plugin_platform_interface: ^2.1.8
rate_limiter: ^1.0.0
stream_video: ^0.10.1
stream_webrtc_flutter: ^1.0.9
stream_webrtc_flutter: ^1.0.10
visibility_detector: ^0.4.0+2

dev_dependencies:
Expand Down
2 changes: 1 addition & 1 deletion packages/stream_video_noise_cancellation/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dependencies:
sdk: flutter
plugin_platform_interface: ^2.0.2
stream_video: ^0.10.1
stream_webrtc_flutter: ^1.0.9
stream_webrtc_flutter: ^1.0.10

dev_dependencies:
flutter_test:
Expand Down
2 changes: 1 addition & 1 deletion packages/stream_video_push_notification/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ dependencies:
stream_video: ^0.10.1
uuid: ^4.2.1
shared_preferences: ^2.3.2
stream_webrtc_flutter: ^1.0.9
stream_webrtc_flutter: ^1.0.10

dev_dependencies:
build_runner: ^2.4.4
Expand Down