You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
build(deps): bump Kotlin to 2.3.21 with matching KSP and Hilt versions - #1887
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
📝 Walkthrough
The version catalog updates Kotlin and Kotlin test JUnit to 2.3.21, KSP to 2.3.11, and Hilt to 2.58. Two serialization test assertions now use explicitly nullable expected arrays.
Suggested reviewers:aleksandar-apostolov
Priority: ⬇️ Low
Merge Risk:⚪ Minimal · up to c3ed0
The dependency and serialization test updates are ready to merge with normal checks.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 …
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly summarizes the primary change: the Kotlin upgrade with matching KSP and Hilt version updates.
Description check
The description includes the required Goal, Implementation, and Testing sections. It explains the version changes, compatibility constraints, test updates, linked issues, and validation results. The C…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description includes the required Goal, Implementation, and Testing sections. It explains the version changes, compatibility constraints, test updates, linked issues, and validation results. The Checklist section is omitted, but the description is otherwise complete.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 2
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🛠️ Fix failing CI checks: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the version list, Then nibbles through each test. Nullable arrays hop into place, While Kotlin takes a step. The rabbit twitches both its ears, And finds the changes dressed.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Closes AND-1701
Move
develop-v2to Kotlin 2.3 so the SDK can usekotlin.time.Instant(replacing ThreeTenABP is AND-1702).Implementation
kotlinandkotlinTestJunit: 2.2.0 → 2.3.21.ksp:2.2.0-2.0.2→2.3.11. KSP versions are independent of Kotlin since 2.3.0. 2.3.12 requires AGP 8.12, and we are on 8.10.1.hilt: 2.56.2 → 2.58. 2.56.2 can't read Kotlin 2.3 metadata, and 2.59 and later require AGP 9.TraceRecordTest: explicitarrayOf<Any?>, because Kotlin 2.3 rejects a reified type parameter inferred as an intersection type.Testing
./gradlew assembleDebug apiCheck testDebugUnitTestpasses, and the API dumps are unchanged.Summary by CodeRabbit
Chores
Tests