Skip to content

Conversation

rahul-lohra
Copy link
Contributor

Goal

Deprecate the fixed audioUsage: Int parameter and replace it with a lambda-based provider. This allows audio usage to be resolved dynamically at invocation time rather than being fixed during construction.

Implementation

  • Added a new constructor parameter audioUsageProvider: () -> Int with default { defaultAudioUsage }.
  • Deprecated the existing audioUsage: Int parameter with a ReplaceWith hint to guide migration.
  • Updated internal references to resolve audio usage by invoking the provider.

Testing

Smoke test livestream tutorial

@rahul-lohra rahul-lohra self-assigned this Sep 29, 2025
@rahul-lohra rahul-lohra requested a review from a team as a code owner September 29, 2025 15:21
Copy link
Contributor

github-actions bot commented Sep 29, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

Copy link
Contributor

github-actions bot commented Sep 29, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.49 MB 11.49 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.70 MB 5.70 MB 0.00 MB 🟢
stream-video-android-ui-compose 5.86 MB 5.86 MB 0.00 MB 🟢

@rahul-lohra rahul-lohra added the pr:improvement Enhances an existing feature or code label Sep 29, 2025
@rahul-lohra rahul-lohra changed the title Runtime resolution audio usage Support dynamic audio usage resolution Sep 29, 2025
@rahul-lohra rahul-lohra changed the title Support dynamic audio usage resolution [WIP]Support dynamic audio usage resolution Sep 29, 2025
@rahul-lohra rahul-lohra marked this pull request as draft September 29, 2025 15:49
Copy link

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:improvement Enhances an existing feature or code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants