-
Notifications
You must be signed in to change notification settings - Fork 112
Add message highlighting on jumping to a quoted message #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e2cef8 to
4264b51
Compare
| showsAllInfo: Bool, | ||
| isInThread: Bool, | ||
| scrolledId: Binding<String?>, | ||
| highlightedMessageId: Binding<String?>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, we can't do this :/ Is there any alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the PR, now using Environment instead of factory param 👍
SDK Size
|
StreamChatSwiftUI XCSize
Show 17 more objects
|
Public Interface public struct ColorPalette
- public var shadow: UIColor
+ public var messageCellHighlightBackground: UIColor
- public var lightBorder: UIColor
+ public var shadow: UIColor
- public var innerBorder: UIColor
+ public var lightBorder: UIColor
- public var border: UIColor
+ public var innerBorder: UIColor
- public var border2: UIColor
+ public var border: UIColor
- public var border3: UIColor
+ public var border2: UIColor
- public var alert: UIColor
+ public var border3: UIColor
- public var alternativeActiveTint: UIColor
+ public var alert: UIColor
- public var inactiveTint: UIColor
+ public var alternativeActiveTint: UIColor
- public var alternativeInactiveTint: UIColor
+ public var inactiveTint: UIColor
- public lazy var messageCurrentUserBackground: [UIColor]
+ public var alternativeInactiveTint: UIColor
- public lazy var messageCurrentUserEmphemeralBackground: [UIColor]
+ public lazy var messageCurrentUserBackground: [UIColor]
- public lazy var messageOtherUserBackground: [UIColor]
+ public lazy var messageCurrentUserEmphemeralBackground: [UIColor]
- public lazy var messageCurrentUserTextColor: UIColor
+ public lazy var messageOtherUserBackground: [UIColor]
- public lazy var messageOtherUserTextColor: UIColor
+ public lazy var messageCurrentUserTextColor: UIColor
- public lazy var quotedMessageBackgroundCurrentUser: UIColor
+ public lazy var messageOtherUserTextColor: UIColor
- public lazy var quotedMessageBackgroundOtherUser: UIColor
+ public lazy var quotedMessageBackgroundCurrentUser: UIColor
- public lazy var reactionCurrentUserColor: UIColor?
+ public lazy var quotedMessageBackgroundOtherUser: UIColor
- public lazy var reactionOtherUserColor: UIColor?
+ public lazy var reactionCurrentUserColor: UIColor?
- public lazy var selectedReactionBackgroundColor: UIColor?
+ public lazy var reactionOtherUserColor: UIColor?
- public var voiceMessageControlBackground: UIColor
+ public lazy var selectedReactionBackgroundColor: UIColor?
- public var messageLinkAttachmentAuthorColor: Color
+ public var voiceMessageControlBackground: UIColor
- public var messageLinkAttachmentTitleColor: Color
+ public var messageLinkAttachmentAuthorColor: Color
- public var messageLinkAttachmentTextColor: Color
+ public var messageLinkAttachmentTitleColor: Color
- public lazy var composerPlaceholderColor: UIColor
+ public var messageLinkAttachmentTextColor: Color
- public lazy var composerInputBackground: UIColor
+ public lazy var composerPlaceholderColor: UIColor
- public lazy var composerInputHighlightedBorder: UIColor
+ public lazy var composerInputBackground: UIColor
- public var navigationBarGlyph: UIColor
+ public lazy var composerInputHighlightedBorder: UIColor
- public var navigationBarTitle: UIColor
+ public var navigationBarGlyph: UIColor
- public var navigationBarSubtitle: UIColor
+ public var navigationBarTitle: UIColor
- public var navigationBarTintColor: Color
+ public var navigationBarSubtitle: UIColor
- public var navigationBarBackground: UIColor?
+ public var navigationBarTintColor: Color
- public var bannerBackgroundColor: UIColor
+ public var navigationBarBackground: UIColor?
-
+ public var bannerBackgroundColor: UIColor
-
+
- public init()
+
+ public init()
public struct MessageRepliesView: View
- public init(factory: Factory,channel: ChatChannel,message: ChatMessage,replyCount: Int,showReplyCount: Bool = true,isRightAligned: Bool? = nil)
+ public init(factory: Factory,channel: ChatChannel,message: ChatMessage,replyCount: Int,showReplyCount: Bool = true,isRightAligned: Bool? = nil,threadReplyMessage: ChatMessage? = nil)
open class ChatChannelViewModel: ObservableObject, MessagesDataSource
- @Published public var listId
+ @Published public var highlightedMessageId: String?
- @Published public var showScrollToLatestButton
+ @Published public var listId
- @Published public var currentDateString: String?
+ @Published public var showScrollToLatestButton
- @Published public var messages
+ @Published public var currentDateString: String?
- @Published public var messagesGroupingInfo
+ @Published public var messages
- @Published public var currentSnapshot: UIImage?
+ @Published public var messagesGroupingInfo
- @Published public var reactionsShown
+ @Published public var currentSnapshot: UIImage?
- @Published public var bouncedMessage: ChatMessage?
+ @Published public var reactionsShown
- @Published public var bouncedActionsViewShown
+ @Published public var bouncedMessage: ChatMessage?
- @Published public var quotedMessage: ChatMessage?
+ @Published public var bouncedActionsViewShown
- @Published public var editedMessage: ChatMessage?
+ @Published public var quotedMessage: ChatMessage?
- @Published public var channelHeaderType: ChannelHeaderType
+ @Published public var editedMessage: ChatMessage?
- @Published public var threadMessage: ChatMessage?
+ @Published public var channelHeaderType: ChannelHeaderType
- @Published public var threadMessageShown
+ @Published public var threadMessage: ChatMessage?
- @Published public var shouldShowTypingIndicator
+ @Published public var threadMessageShown
- @Published public var scrollPosition: String?
+ @Published public var shouldShowTypingIndicator
- @Published public private var loadingNextMessages: Bool
+ @Published public var scrollPosition: String?
- @Published public var firstUnreadMessageId: String?
+ @Published public private var loadingNextMessages: Bool
- public var currentUserMarkedMessageUnread: Bool
+ @Published public var firstUnreadMessageId: String?
- @Published public private var channel: ChatChannel?
+ public var currentUserMarkedMessageUnread: Bool
- public var isMessageThread: Bool
+ @Published public private var channel: ChatChannel?
-
+ public var isMessageThread: Bool
-
+
- public init(channelController: ChatChannelController,messageController: ChatMessageController? = nil,scrollToMessage: ChatMessage? = nil)
+
-
+ public init(channelController: ChatChannelController,messageController: ChatMessageController? = nil,scrollToMessage: ChatMessage? = nil)
-
+
- public func scrollToLastMessage()
+
- public func messageSentTapped()
+ public func scrollToLastMessage()
- public func jumpToMessage(messageId: String)-> Bool
+ public func messageSentTapped()
- open func handleMessageAppear(index: Int,scrollDirection: ScrollDirection)
+ public func jumpToMessage(messageId: String)-> Bool
- open func groupMessages()
+ open func handleMessageAppear(index: Int,scrollDirection: ScrollDirection)
- public func showReactionOverlay(for view: AnyView)
+ open func groupMessages()
- public func showBouncedActionsView(for message: ChatMessage)
+ public func showReactionOverlay(for view: AnyView)
- public func deleteMessage(_ message: ChatMessage)
+ public func showBouncedActionsView(for message: ChatMessage)
- public func resendMessage(_ message: ChatMessage)
+ public func deleteMessage(_ message: ChatMessage)
- public func editMessage(_ message: ChatMessage)
+ public func resendMessage(_ message: ChatMessage)
- open func messageActionExecuted(_ messageActionInfo: MessageActionInfo)
+ public func editMessage(_ message: ChatMessage)
- @objc public func onViewAppear()
+ open func messageActionExecuted(_ messageActionInfo: MessageActionInfo)
- @objc public func onViewDissappear()
+ @objc public func onViewAppear()
- public func setActive()
+ @objc public func onViewDissappear()
+ public func setActive() |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅


🔗 Issue Links
Resolve https://linear.app/stream/issue/IOS-571
🎯 Goal
Add message highlighting on jumping to a quoted message
🧪 Manual Testing Notes
channeland scroll to some older pagethreadin this messagethreadthreadthread☑️ Contributor Checklist
docs-contentrepo