chore: update build system #1468
Draft
+1,497
−2,154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -225 kB (-42.97%) 🎉 Total Size: 299 kB
|
arnautov-anton
force-pushed
the
chore/update-build-system
branch
2 times, most recently
from
7517db1 to
bedeada
Compare
arnautov-anton
force-pushed
the
chore/update-build-system
branch
from
bedeada to
48f659b
Compare
arnautov-anton
force-pushed
the
chore/update-build-system
branch
from
48f659b to
529fdf6
Compare
arnautov-anton
commented
Feb 14, 2025
scripts/bundle-cjs.mjs
Outdated
Comment on lines
41
to
50
| const browserPlugin = { | ||
| name: 'ignoreBrowser', | ||
| setup: (build) => { | ||
| const options = build.initialOptions; | ||
|
|
||
| if (options.platform !== 'browser') return; | ||
|
|
||
| build.onResolve({ filter: /(node:.+)|(jsonwebtoken)/ }, async ({ path }) => ({ path, external: true })); | ||
| }, | ||
| }; |
There was a problem hiding this comment.
I'm pretty sure this isn't the right approach, I'm going to have to find a similar way of doing what they did in Rollup:
stream-chat-js/rollup.config.js
Lines 15 to 19 in 7450517
(dropping imports for crypto, jsonwebtoken and https altogether from browser version)
There was a problem hiding this comment.
Nevermind, this seems to work just as well. :)
arnautov-anton
force-pushed
the
chore/update-build-system
branch
4 times, most recently
from
4249c89 to
d05514f
Compare
arnautov-anton
force-pushed
the
chore/update-build-system
branch
4 times, most recently
from
3a561a8 to
c3a267d
Compare
arnautov-anton
force-pushed
the
chore/update-build-system
branch
from
c3a267d to
0665ec1
Compare
arnautov-anton
commented
Feb 15, 2025
| "/src", | ||
| "readme.md", | ||
| "license" | ||
| "/dist" |
There was a problem hiding this comment.
From npm documentation:
Certain files are always included, regardless of settings:
- package.json
- README
- LICENSE / LICENCE
- The file in the "main" field
- The file(s) in the "bin" field
Not sure why we were releasing sourcefiles as well though.
arnautov-anton
commented
Feb 15, 2025
Comment on lines
+55
to
+61
| "@babel/plugin-proposal-class-properties": "^7.18.6", | ||
| "@babel/plugin-proposal-object-rest-spread": "^7.20.7", | ||
| "@babel/plugin-transform-object-assign": "^7.25.9", | ||
| "@babel/plugin-transform-runtime": "^7.26.9", | ||
| "@babel/preset-env": "^7.26.9", | ||
| "@babel/preset-typescript": "^7.26.0", | ||
| "@babel/register": "^7.25.9", |
There was a problem hiding this comment.
Unfortunately these are still needed for the Mocha to run properly, using different loader generated a TON of other issues I wasn't comfortable dealing with within this PR, updates should suffice for now.
arnautov-anton
commented
Feb 15, 2025
| "declarationDir": "./dist/types", | ||
| "module": "commonjs", | ||
| "target": "ES5" | ||
| "module": "ES2020", |
There was a problem hiding this comment.
Note - important change here, the default output is now ESM.
arnautov-anton
commented
Feb 15, 2025
| "module": "commonjs", | ||
| "target": "ES5" | ||
| "module": "ES2020", | ||
| "target": "ES6", |
There was a problem hiding this comment.
We should probably review the target too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes, What, Why and How?