[CHA-403] Private messaging #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totalimmersion
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz,
arnautov-anton,
MartinCupela and
myandrienko
as code owners
|
Size Change: 0 B Total Size: 467 kB ℹ️ View Unchanged
|
vishalnarkhede
approved these changes
Jan 28, 2025
| @@ -15,8 +15,5 @@ jobs: | |||
|
|
|||
| - uses: ./.github/actions/setup-node | |||
|
|
|||
| - name: Commit message lint | |||
| run: echo "${{ github.event.pull_request.title }}" | yarn commitlinter | |||
There was a problem hiding this comment.
Instead of removing the linter we could use FIXES CHA-403 and maintain the rules for commit description.
There was a problem hiding this comment.
Following those rules would help us in the future using automated release with tools like semantic-release
There was a problem hiding this comment.
of course we could, but what is the purpose? all these commits gets squashed anyways.
There was a problem hiding this comment.
I understand this lints the PR title that is later used when squash merging the PR. Or does it do sth different?
There was a problem hiding this comment.
it's linting individual commits as well within the branch/pr.
totalimmersion
deleted the
feature/cha-398_restricted_message_visibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding private messaging for a select list of users in a channel. If the user who sends the message has the
CreateRestrictedVisibilityMessagepermission, then by adding `restricted_visibility: [ 'john', 'jane' ] would limit the visibility of that message to only john and jane. The other members of the channel can't see the message. The sender of the message can always see it.